Fix issue 23 #24
Open
Fix issue 23 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Genomic coordinates can be flipped to order (end,start) for reverse-strand features when adding hmmer and interpro domains. Unflip flipped coordinates in the `has_overlap` and `get_overlap` functions. See HerwigLab#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #23
The simplest fix was to modify the functions
has_overlapandget_overlapto change coordinates to (start, end) order if they are flipped in the input. Updated the function docstrings.I verified the output of the downstream
add_domains_to_tablefunction with the example in the issue above. Adding domains with hmmer currently doesn't work properly with isotools v2.0.0 and the latest pyhmmer but I used my fork (see PR #18 ) that fixes the issue.