修正工作流构件无法下载的问题

[Silverteal]

Github Actions 的构件系统对非ASCII字符的支持有些神经，会导致构件无法下载。
此PR暂时缓解了这个问题……

[allMagicNB]

6

[Silverteal]

要不要加一行让如果上传文件失败就变成 error？

1.上传失败本来就会出错
2.上传是正常的，会出错的是下载流程

[3gf8jv4dv]

Personally, I really do not see any projects using non-ASCII characters in GHA artifact file names. And now it is indeed impossible to download. I remember trying to download it before, but I do not remember if it worked properly. So this PR is very necessary.

Speaking of this, I just happen to have some opinions on the GHA of this project, so I will digress.

Could we consider adding information about the commit hash that triggered the build in the artifact package file name? This allows you to download multiple artifacts of different builds at the same time without overwriting them, and to distinguish which commit’s build an artifact contains. The best practice I have seen within the Minecraft community is Prism Launcher.

I personally agree with your idea of ​​uploading GHA artifacts to Releases. However, there are still many forms. Some projects upload artifacts to a fixed tag, and each time a new build is triggered, the previous artifacts are overwritten; some projects create a new tag every time a build is triggered and upload the artifacts to it. I would like to hear your opinion.

[3gf8jv4dv]

Is the second half of the sentence still necessary when only English is used as the name?

[Silverteal]

Is the second half of the sentence still necessary when only English is used as the name?

In fact I didn't want to add the second part at the first time, but someone suggested doing so. I'm not going to use the second part, at least before localized friendly name can be included.

[Silverteal]

Personally, I really do not see any projects using non-ASCII characters in GHA artifact file names. And now it is indeed impossible to download. I remember trying to download it before, but I do not remember if it worked properly. So this PR is very necessary.

Speaking of this, I just happen to have some opinions on the GHA of this project, so I will digress.

Could we consider adding information about the commit hash that triggered the build in the artifact package file name? This allows you to download multiple artifacts of different builds at the same time without overwriting them, and to distinguish which commit’s build an artifact contains. The best practice I have seen within the Minecraft community is Prism Launcher.

I personally agree with your idea of ​​uploading GHA artifacts to Releases. However, there are still many forms. Some projects upload artifacts to a fixed tag, and each time a new build is triggered, the previous artifacts are overwritten; some projects create a new tag every time a build is triggered and upload the artifacts to it. I would like to hear your opinion.

In my mind, using release instead of artifact is only for the reason that artifacts can't use non-ascii names. So more configurations is not under my consideration. Due to the fact that Github is not the major method for PCL's distributing, maintaining a system of releases seems to pay more than its benefits.

Speaking of signatures, I don't have much experience on GHA, but adding something to specify different builds seems like a good idea.

[LTCatt]

因为我确实不熟 GHA，所以 review 就交给大家了 orz

[LTCatt]

fixed by #4009