Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正工作流构件无法下载的问题 #3979

Closed
wants to merge 8 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# 定义工作流名称
name: 构建 PCL
name: 编译 PCL

# 定义触发器
on:
Expand All @@ -23,17 +23,19 @@ jobs:

strategy:
# 定义矩阵,矩阵中每组都会单独执行,并使矩阵本身成为可用的上下文
# 由于一些奇葩的原因,Artifacts使用中文作为名称会导致它无法被下载,因此此处使用英文名。
# 或许后续可以试着直接发Release?
matrix:
include:
- name: 开发版
- name: 'Debug with symbols'
configuration: Debug
- name: 开发版
- name: 'Debug'
configuration: Snapshot
- name: 快照版
- name: 'Snapshot'
configuration: Release
- name: 快照版
- name: 'Snapshot from update'
configuration: ReleaseUpdate
- name: 正式版
- name: 'Release'
configuration: BETA

# 显然,只有Windows才能构建.NET Framework程序
Expand Down Expand Up @@ -69,11 +71,12 @@ jobs:
# 由于路径包含空格,使用环境变量传入路径,避免令人疑惑的引号写法
Project_Path: Plain Craft Launcher 2\Plain Craft Launcher 2.vbproj

# 第四步,上传编译产物到Artifacts
- name: 上传编译产物
# 第四步,打包并上传编译产物到Artifacts
- name: 打包并上传编译产物
uses: actions/upload-artifact@v4
with:
# Artifact压缩包名称,此处命名为友好名称_原始名称
name: ${{ matrix.name }}_${{ matrix.configuration }}
# Artifact压缩包名称,此处命名为友好名称
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second half of the sentence still necessary when only English is used as the name?

Copy link
Contributor Author

@Silverteal Silverteal Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second half of the sentence still necessary when only English is used as the name?

In fact I didn't want to add the second part at the first time, but someone suggested doing so. I'm not going to use the second part, at least before localized friendly name can be included.

name: ${{ matrix.name }}
# 将要上传的对象,将被压缩为Artifact压缩包
path: Plain Craft Launcher 2\obj\${{ matrix.configuration }}\Plain Craft Launcher 2.exe