Auto suggest environment variables using l2 --env <path> command
#10
Conversation
- Handling this case in catch block
- Using `l2 --env ${l2FilePath}` go lang binary command to fetch env.
- Removed old searching envs in the frontend as performance was low.
- Moved all the suggestions and replacing part to new file.
lovestaco
changed the title
l2 --env command
lovestaco
changed the title
l2 --env commandl2 --env <path> command
In documentation, we should settle with a proper name - something like |
src/extension.ts
Outdated
|
|
||
| // Level1 command pallette | ||
| function isDefault(defaultClient: string, client: string) { |
There was a problem hiding this comment.
What is this function about? not able to infer from context.
There was a problem hiding this comment.
Maybe it should go into a group of functions in a different file. My best guess is it's related to the code generation library selection.
There was a problem hiding this comment.
Yeah moved everything to new files.
src/extension.ts
Outdated
| }, | ||
| } | ||
| ); | ||
| let suggestEnvVariables = suggestENVS(); |
src/suggestEnvironmentVars.ts
Outdated
|
|
||
| } | ||
|
|
||
| export function suggestENVS() { |
src/suggestEnvironmentVars.ts
Outdated
| // const commandOutput = execSync(`./build/l2 --env ${l2FilePath}`, { cwd: "/home/lovestaco/repos/Lama2", }).toString(); // For local debugging | ||
| const commandOutput = execSync(`l2 --env ${l2FilePath}`).toString(); | ||
|
|
||
| const mapStartIndex = commandOutput.indexOf("{"); |
There was a problem hiding this comment.
Ideally, we don't want to rely on this. Say, if a logger has a { character, this is going to break. So, if at all possible we have a full quiet mode in the command output itself, so that there's no need to find the map's starting point. We should simply be able to do JSON.parse on incoming string.
There was a problem hiding this comment.
Yes made the change
What type of MR is this?
Description
Edit1:
Merging old
copygitbranch autosuggest env feature.Edit2:
This MR adds the feature of suggesting root and local variables.
l2 --env <l2FilePath>.Important code file to start Code Review from
extention.tsRelated PR
Global variable support and Generate env JSON option
Added tests?