Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rosetta caveats #177913

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wickles
Copy link
Contributor

@wickles wickles commented Jun 27, 2024

After making any changes to a cask, existing or new, verify:


Added the requires_rosetta caveat to many casks with only intel builds available. I'm sure I missed some but tried to cover the most popular and most obvious ones.

Methodologies used:

  • grep for relevant url substrings such as: intel, x86, x64, amd64
  • manual inspection via file command and Info box for apps

Potential issues: some casks might get updated in the future with arm builds so then a maintainer will need to notice and remove the caveat, especially for universal builds. Note in particular there are some casks with arm builds for development versions but not for the stable version.

  • examples: beyond-compare (beta), virtualbox (beta), dolphin (beta/dev), retroarch/metal

Related problem: I identified some casks that are only built for 32-bit intel, so they do not work with Rosetta. Not sure what is the right way to handle these -- require intel arch? Can make a separate PR for this.

  • examples: pgadmin3, nightingale, mame, gameranger

@bevanjkay
Copy link
Member

Thank you for taking the time to create this PR @wickles
Have all of the changes been manually verified, or do some make assumptions based on the presence of x64 etc..
The only true way to check this is to manually verify, as you have with some of them.

@SMillerDev
Copy link
Member

Yeah, I'm sceptical that all are still not usable on modern macs without Rosetta. It's not unlikely upstreams just made universal binaries without changing the name.

@krehel
Copy link
Member

krehel commented Jun 27, 2024

/rebase

@SMillerDev
Copy link
Member

I think these are too many files for test bot to handle. And we need to have one commit per casks anyway. Could you split this in a PR per ~50 casks?

@wickles
Copy link
Contributor Author

wickles commented Jun 27, 2024

Have all of the changes been manually verified, or do some make assumptions based on the presence of x64 etc..
The only true way to check this is to manually verify, as you have with some of them.

I have checked many but not all. The new audit should help identify any false positives, once the issues are worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants