Conversation
Last 4 values changes from 1e-37 to zero. This is a valid approximation having those values 30 order of magnitude at least lower than other minimum values.
Last 5 values changes from 1e-37 to zero. This is a valid approximation having those values 30 order of magnitude at least lower than other minimum values.
One value changed from 1e-37 to zero. This is a valid approximation having those values 30 order of magnitude at least lower than other minimum values.
dodu94
requested changes
Mar 20, 2026
Collaborator
dodu94
left a comment
dodu94
left a comment
There was a problem hiding this comment.
Fair change but before approval data should be changed in a local istance of JADE, run the post-processing and verify that the issue is solved
Collaborator
|
I re-run the processing with the new data and can confirm that the issue goes away: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extremely low, and likely, unphisical experimental results of the neutron flux of Cu, Mn, Mo cases have been set to zeto in order to avoid an unproper post processing error in JADE. This is considered a proper approximation as those values 30 order of magnitudes lower than nearby ones.