Call process.exit with step exit code and filter env vars with spaces
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Signed-off-by: Sanjula Ganepola <[email protected]>
Collaborator
Author
|
@worksofliam When you have some time, can you review this PR :) |
worksofliam
approved these changes
Dec 11, 2024
Member
worksofliam
left a comment
worksofliam
left a comment
There was a problem hiding this comment.
@SanjulaGanepola Do you want a release for this asap?
Collaborator
Author
|
No rush on this. Just wanted to ping you since I didn't have access to request reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
process.exitwith step exit code:In a workflow for Bob, I noticed that the entire workflow was passing even though a step was failing. This is even reproduceable by simply adding a step with
--cmd "exit 1"which it logs that it fails but the workflow passes. Check out this execution and workflow file as an example.Just noticed when running locally on my system I had some environment variables (from IntelliJ) which caused the
envstep to failed since it had spaces.First time also running ibmi-ci from the source code directly, so made these improvements:
.env.sample