Skip to content

Call process.exit with step exit code and filter env vars with spaces #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Call process.exit with step exit code and filter env vars with spaces #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f194b91
Add env sample
SanjulaGanepola Dec 6, 2024
db4f871
Fix workspace folder in launch configuration
SanjulaGanepola Dec 6, 2024
317604c
Call process.exit with step exit code
SanjulaGanepola Dec 6, 2024
614a170
Filter environment variables with spaces
SanjulaGanepola Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
IBMI_HOST=
IBMI_USER=
IBMI_PASSWORD=
IBMI_SSH_PORT=
3 changes: 2 additions & 1 deletion .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ test
src
!dist/src
node_modules
.vscode
.vscode
.env.sample
10 changes: 5 additions & 5 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
"name": "Debug ibmi-ci CLI",
"type": "node",
"request": "launch",
"program": "${workspaceFolder:ibmicli}/dist/index.js",
"program": "${workspaceFolder:ibmi-ci}/dist/index.js",
"sourceMaps": true,
"args": [
"--lcwd", "${workspaceFolder:ibmicli}/src",
"--lcwd", "${workspaceFolder:ibmi-ci}/src",
"--cmd", "mkdir -p './builds/icisrc'",
"--ignore", "--cmd", "woejhraljdsfn",
"--rcwd", "./builds/icisrc",
Expand All @@ -27,13 +27,13 @@
"type": "npm",
"script": "webpack:dev"
},
"envFile": "${workspaceFolder:ibmicli}/.env"
"envFile": "${workspaceFolder:ibmi-ci}/.env"
},
{
"name": "Debug ibmi-ci yaml",
"type": "node",
"request": "launch",
"program": "${workspaceFolder:ibmicli}/dist/index.js",
"program": "${workspaceFolder:ibmi-ci}/dist/index.js",
"sourceMaps": true,
"args": [
"--file", "examples/exampleA.yml",
Expand All @@ -42,7 +42,7 @@
"type": "npm",
"script": "webpack:dev"
},
"envFile": "${workspaceFolder:ibmicli}/.env"
"envFile": "${workspaceFolder:ibmi-ci}/.env"
},
]
}
2 changes: 2 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ async function main() {

const result = await executor.executeSteps({log: logger});
executor.dispose();
console.log(`ibmi-ci completed with exit code ${result.code}.`);
process.exit(result.code);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/steps/actions/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class EnvironmentStep extends StepI {
`CommonProgramFiles(x86)`, `ProgramFiles(x86)`
];

const environmentVariables = Object.keys(process.env).filter(key => !ignoredEnvironmentVariables.includes(key) && !key.includes('.'));
const environmentVariables = Object.keys(process.env).filter(key => !ignoredEnvironmentVariables.includes(key) && !key.includes('.') && !key.includes(' '));
const commandString = environmentVariables.map(key => `${key}='${process.env[key]}'`).join(` `);

this.log(`Setting environment variables: ${environmentVariables.join(`, `)}`);
Expand Down