feat(helm): add service annotations and CACHE_TYPE none option #2088
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add mcpContextForge.service.annotations for LoadBalancer configuration (e.g., AWS NLB, GCP load balancer annotations) - Add "none" as a valid CACHE_TYPE option in values.schema.json to allow disabling caching entirely These changes were extracted from PR #1798, which was superseded by existing implementations for external PostgreSQL and secret injection. Co-authored-by: Mihai Criveti <crivetimihai@gmail.com> Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the still-valid features from #1798 (now closed), which was superseded by existing implementations for external PostgreSQL and secret injection.
Changes:
mcpContextForge.service.annotationsto allow LoadBalancer configuration (e.g., AWS NLB, GCP load balancer annotations)Why this matters:
Attribution
Original work by @jinzishuai in #1798 - thank you for identifying these gaps!
Files changed:
charts/mcp-stack/templates/service-mcp.yaml- Added annotations template blockcharts/mcp-stack/values.schema.json- Added annotations schema and "none" to CACHE_TYPE enumcharts/mcp-stack/values.yaml- Added annotations defaultCloses #1722 (partial - service annotations portion)