Skip to content

feat(helm): add service annotations and CACHE_TYPE none option #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crivetimihai merged 1 commit into from
Jan 14, 2026
+14 −1
Merged

feat(helm): add service annotations and CACHE_TYPE none option #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/mcp-stack/templates/service-mcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ metadata:
name: {{ include "mcp-stack.fullname" . }}-mcpgateway
labels:
{{- include "mcp-stack.labels" . | nindent 4 }}
{{- with .Values.mcpContextForge.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.mcpContextForge.service.type }}
selector:
Expand Down
10 changes: 9 additions & 1 deletion charts/mcp-stack/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@
"minimum": 1,
"maximum": 65535,
"default": 80
},
"annotations": {
"type": "object",
"description": "Service annotations (e.g., for AWS NLB, GCP load balancer configuration)",
"additionalProperties": {
"type": "string"
},
"default": {}
}
},
"additionalProperties": false
Expand Down Expand Up @@ -498,7 +506,7 @@
"CACHE_TYPE": {
"type": "string",
"description": "Cache backend type",
"enum": ["redis", "memory", "database"],
"enum": ["redis", "memory", "none", "database"],
"default": "redis"
},
"CACHE_PREFIX": {
Expand Down
1 change: 1 addition & 0 deletions charts/mcp-stack/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ mcpContextForge:
service:
type: ClusterIP
port: 80 # external port → containerPort below
annotations: {} # Service annotations (e.g., for AWS NLB configuration)

containerPort: 4444 # port the app listens on inside the pod

Expand Down
Loading