Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointing frame updates #814

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Sep 6, 2024

Change Summary

Overview

Adds ability to combine different pointings into the frame kernel.

Updated Files

  • kernels.py
    • Adds ability to combine different pointings into the frame kernel.
    • Results in imap_pointing_frame.bc which will be used for ENA teams for l1b.

Testing

  • test_kernels.py
    • Tests kernels.py

Necessary test data:
IMAP_spacecraft_attitude.bc
imap_pointing_frame.bc

@laspsandoval laspsandoval self-assigned this Sep 6, 2024
@laspsandoval laspsandoval added the SPICE Related to SPICE label Sep 6, 2024
@vmartinez-cu
Copy link
Contributor

What does "et_" refer to in many of the variable names. Is this ephemeris time?

@laspsandoval laspsandoval changed the title Ultra l1b annotated 1 Pointing frame updates Sep 9, 2024
@laspsandoval
Copy link
Contributor Author

What does "et_" refer to in many of the variable names. Is this ephemeris time?

Yes. That is correct.

Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed most of the code and have some feedback. I ran out of time and haven't done an in-depth review of the tests. I will plan to come finish my review after school pickup or sometime this evening.

imap_processing/spice/kernels.py Outdated Show resolved Hide resolved
imap_processing/spice/kernels.py Show resolved Hide resolved
imap_processing/spice/kernels.py Show resolved Hide resolved
imap_processing/spice/kernels.py Show resolved Hide resolved
imap_processing/spice/kernels.py Outdated Show resolved Hide resolved
imap_processing/spice/kernels.py Outdated Show resolved Hide resolved
imap_processing/tests/spice/test_kernels.py Outdated Show resolved Hide resolved
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing comments.

@laspsandoval laspsandoval merged commit 5c010cd into IMAP-Science-Operations-Center:dev Sep 12, 2024
17 checks passed
@laspsandoval laspsandoval deleted the ultra_l1b_annotated_1 branch September 12, 2024 20:57
@bourque bourque added this to the Sept 2024 milestone Sep 16, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPICE Related to SPICE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants