Skip to content

Conversation

Copy link

Copilot AI commented Nov 12, 2025

Summary

Direct JSON string comparison in workflow conditions fails on formatting differences (whitespace, ordering) despite semantic equality.

Changes

Replace string comparison with count-based boolean flag:

  • Add has-cached-apps output to prepare-matrix job
  • Compute by comparing APPS_TO_BUILD_COUNT < APPS_CHECKED
  • Update restore-cached-apps condition from string equality to boolean check

Before:

if: needs.prepare-matrix.outputs.apps-to-build != needs.prepare-matrix.outputs.external-apps-matrix

After:

if: needs.prepare-matrix.outputs.has-cached-apps == 'true'

TODO

  • Replace JSON string comparison with robust check
  • Test logic handles all scenarios (all cached, some cached, none cached)

Checklist


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@printminion-co printminion-co marked this pull request as ready for review November 12, 2025 08:21
Copilot AI changed the title [WIP] Update to address feedback on 'dont rebuild already built apps' IONOS(build): fix JSON comparison in workflow cache detection Nov 12, 2025
@printminion-co printminion-co merged commit bf8e016 into mk/poc/dont_rebuild_already_built_apps Nov 12, 2025
6 of 32 checks passed
Copilot AI requested a review from printminion-co November 12, 2025 08:22
@printminion-co printminion-co deleted the copilot/sub-pr-127 branch November 12, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants