Skip to content

IONOS(build): fix JSON comparison in workflow cache detection #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 2 commits into from
Nov 12, 2025
Merged

IONOS(build): fix JSON comparison in workflow cache detection #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc907cd
Initial plan
Copilot Nov 12, 2025
27af931
IONOS(build): replace JSON string comparison with robust count-based …
Copilot Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/build-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
outputs:
apps-to-build: ${{ steps.detect.outputs.apps-to-build }}
external-apps-matrix: ${{ steps.set-matrix.outputs.matrix }}
has-cached-apps: ${{ steps.detect.outputs.has-cached-apps }}
steps:
- name: Checkout repository
uses: actions/checkout@v5
Expand Down Expand Up @@ -621,6 +622,14 @@ jobs:
echo "$APPS_TO_BUILD" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

# Determine if there are cached apps by comparing counts
# If apps-to-build count is less than total apps, some are cached
if [ $APPS_TO_BUILD_COUNT -lt $APPS_CHECKED ]; then
echo "has-cached-apps=true" >> $GITHUB_OUTPUT
else
echo "has-cached-apps=false" >> $GITHUB_OUTPUT
fi

echo ""
if [ $APPS_TO_BUILD_COUNT -eq 0 ]; then
echo "🎉 All apps are cached! No builds needed."
Expand Down Expand Up @@ -727,8 +736,8 @@ jobs:
restore-cached-apps:
runs-on: ubuntu-latest
needs: prepare-matrix
# Only run if there are cached apps (when apps-to-build is not the full matrix)
if: needs.prepare-matrix.outputs.apps-to-build != needs.prepare-matrix.outputs.external-apps-matrix
# Only run if there are cached apps (when not all apps need to be built)
if: needs.prepare-matrix.outputs.has-cached-apps == 'true'

permissions:
contents: read
Expand Down
Loading