This PR competes with #607 and #622 for the same feature (#604). Only one will be merged — first clean + scoped + tested + DCO-passing wins.

👋 Still actively working on this PR!

Acknowledging the competition with #607 and #622 for the same feature (#604). I've reviewed all three implementations and here's where we stand:

Current blockers on #611 (shared with competitors):

• ❌ DCO check — the DCO workflow itself is failing with Node.js 20 deprecation errors on the runner. I'll fix this by adding Signed-off-by to the commit. Could you confirm whether the DCO infra issue is also being addressed on the repo side?
• ❌ Audit check — also failing due to Node.js 20 deprecation in actions.

What makes #611 competitive:

• ✅ Clean single commit with no merge history
• ✅ More flexible feedback UX: y/n/c=comment/Enter=skip with structured logging
• ✅ Graceful handling of non-interactive environments (EOFError/KeyboardInterrupt)
• ✅ Proper --feedback flag parsing integrated into the existing arg loop
• ✅ audit-shape and isolate checks passing

Next steps I'm planning:

1. Add Signed-off-by to the commit to resolve DCO
2. Consider incorporating result_ids into feedback logs for richer tracking
3. Keep the scope tight — only search_knowledge.py modified, no external deps

Is there any specific area you'd like me to focus on to make this the winning PR? Happy to iterate.

cc @Ikalus1988

Thanks for the detailed update. To answer your questions:

1. DCO infra — the DCO check itself works fine; the Node.js deprecation warnings are cosmetic and don't block the check. The real blocker is missing Signed-off-by: in commits. Adding it will pass DCO.

2. What to focus on — this PR is competing with feat: add --feedback flag + search-feedback.jsonl (#604) #607 and feat(search): add --feedback flag for search result quality feedback loop #622 for [Search][Bounty] Add search result quality feedback loop to search_knowledge.py #604. Current ranking:

   • feat(search): add --feedback flag for search result quality feedback loop #622 (gpcaom-svg) — already reviewed, clean single-file change, Approve pending DCO
   • feat: add --feedback flag for search result quality feedback loop (#604) #611 (you) — competitive, needs DCO
   • feat: add --feedback flag + search-feedback.jsonl (#604) #607 (Byaigo) — needs DCO

   To win: fix DCO first, then keep scope tight. Your y/n/c=comment/Enter=skip UX is a nice touch — keep it.

Fix DCO:

git commit --amend --signoff
git push --force-with-lease

@Ikalus1988 DCO fixed! Rebased onto upstream/main, resolved conflict in search_knowledge.py (preserved both _collect_feedback and _prompt_feedback), and added Signed-off-by to the commit. Please re-check the DCO check when available. Thanks!

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Closing — this work has been superseded by main branch implementation (v2.13.0/v2.14.0). The intake endpoint, feedback flag, and triage pipeline are already in place. Thank you for the contribution.