-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[WIP] feat(dashboard): Only fetch secret value on relevant actions #4545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8f8e8d3
wip
scott-ray-wilson 5a4b83d
improvements: address feedback progress
scott-ray-wilson a95f491
improvements: address feedback 2
scott-ray-wilson f1f391f
improvements: fix commit changes with value retrieval
scott-ray-wilson 120b767
improvement: remove comments
scott-ray-wilson 999ce3f
improvements: resolve more commit state issues form value reveal change
scott-ray-wilson 91d3ed6
improvement: reduce code duplication for copy value
scott-ray-wilson 55b240f
improvement: skip edit/delete permissions for personal secrets
scott-ray-wilson c6c3f2c
improvements: address more feedback
scott-ray-wilson 1a995b6
merge main
scott-ray-wilson 3701858
improvements: final feedback
scott-ray-wilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.