Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ros2-development into ros2-hkr #2954

Merged
merged 112 commits into from
Dec 29, 2023
Merged

Merge ros2-development into ros2-hkr #2954

merged 112 commits into from
Dec 29, 2023

Conversation

Arun-Prasad-V
Copy link
Contributor

No description provided.

Arun-Prasad-V and others added 30 commits August 9, 2023 18:40
@Arun-Prasad-V
Added pointcloud and dual camera examples
a3e046a
@SamerKhshiboun
support color and depth/ir formats
c785bf5
@SamerKhshiboun
remove unsupported models
e05a75b
@Arun-Prasad-V
added align_depth and get params from YAML examples
1901d2c
@Arun-Prasad-V
Updated rs_launch param names
5663e71
@Arun-Prasad-V
updated rs_launch
b5e57d5
@Arun-Prasad-V
Updated the rs_launch.py params
116ac2e
@SamerKhshiboun
Merge branch 'ros2-development' into remove_l500_sr300
f2a389e
@Arun-Prasad-V
updated node output setting
7fef703
@Arun-Prasad-V
Create /imu topic only when motion streams enabled
e14ba75
@Arun-Prasad-V
Get the topic to subscribe from user
00621dc
@hyunseok-yang
Apply camera name in topics
180a711
@PrasRsRos
Added the changes from IntelRealSense#2857 and adapted the tests acco…
af3cd22 
…rdingly
@PrasRsRos
Updated readme
3fc9f1d
@PrasRsRos
modified service call device_info also
ec52d3b
@PrasRsRos
minor change in readme
bd385e9
@SamerKhshiboun
PR IntelRealSense#2857 from lge-ros2: Apply camera name in topics
c92ddf0
@SamerKhshiboun
Merge PR IntelRealSense#2859 from PrasRsRos: Fix tests (topic now has…
e3726b9 
… camera name)
@SamerKhshiboun
fix readme and nodefactory for ros2 run
5d0695a
@SamerKhshiboun
Update README.md
30a70e1
@SamerKhshiboun
Merge branch 'ros2-development' into imu
1801cfc
@SamerKhshiboun
merge
8405872
@SamerKhshiboun
Update README.md
327e602
@Nir-Az
PR IntelRealSense#2863 from IntelRealSense: Update README.md
2cf7290
@PrasRsRos
Added live camera tests
66ba4ee
@Nir-Az
PR IntelRealSense#2861 from SamerKhshiboun: fix readme and nodefactor…
07d7025 
…y for ros2 run
@PrasRsRos
Updated readme and imu tests
6922d4d
@PrasRsRos
static_tf fix
a20eb25
@SamerKhshiboun
PR IntelRealSense#2839 from Arun-Prasad: Added ros2 examples
3cb506d
@PrasRsRos
Added tf and tf_static tests
c80e471
PrasRsRos and others added 24 commits October 5, 2023 18:50
@PrasRsRos
added markers for d415 d455 specific tests
1376bb7
@PrasRsRos
Merge branch 'add-live-camera-tests' of https://github.com/PrasRsRos/…
b150072 
…realsense-ros into add-live-camera-tests
@PrasRsRos
fixed live camera connection checking
8e499f1
@SamerKhshiboun
Merge PR IntelRealSense#2865 from PrasRsRos: add live camera tests
8de679b
@SamerKhshiboun
Update README.md
218e327
@SamerKhshiboun
Update README.md
b1e3963
@SamerKhshiboun
Update README.md
88818df
@SamerKhshiboun
Merge PR IntelRealSense#2901 from SamerKhshiboun: Update Anchors Link…
8834e34 
…s In README.md
@Arun-Prasad-V
Update main.yml
9ef9638 
Using setup-ros v0.7
@Nir-Az
PR IntelRealSense#2943 from Arun-Prasad-V: Update main.yml
4679aa4
@Arun-Prasad-V
Disabling hdr while updating exposure & gain values
e09414d
@Arun-Prasad-V
Merge branch 'IntelRealSense:ros2-development' into hdr_enabled
dc6cbdc
@gwen2018
add error handling to avoid crash when asic temperature monitor occas…
573d6a7 
…ionally fails
@Arun-Prasad-V
Return failure in SetParam callback in case of error
8384c89
@Nir-Az
PR IntelRealSense#2946 from gwen2018: fix ros random crash with error…
91c0f35 
… hw monitor command for asic temperature failed
@Nir-Az
PR IntelRealSense#2934 from Arun-Prasad-V: Disabling hdr while updati…
734f92a 
…ng exposure & gain values
@Arun-Prasad-V
Fixing the data_type of ROS Params exposure & gain
c5e5d3b
@Arun-Prasad-V
Added live camera test for dynamic seq_id update
25ceeae
@Arun-Prasad-V
Disabling HDR during INIT
4610843
@Nir-Az
PR IntelRealSense#2948 from Arun-Prasad-V: Disabling HDR during INIT
7bf5176
@Nir-Az
PR IntelRealSense#2940 from Arun-Prasad-V: Fixing the data_type of RO…
9d0a77c 
…S Params exposure & gain
@Arun-Prasad-V
Added urdf & mesh files for D405 model
0ab7e4f
@Nir-Az
PR IntelRealSense#2953 from Arun-Prasad-V: Added urdf & mesh files fo…
d7b029f 
…r D405 model
@Arun-Prasad-V
Merge branch 'ros2-development' into merge_from_dev_to_ros2_hkr_27_12…
84e2dd8 
…_2023
Nir-Az
Nir-Az approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still draft or ready for merge?

@Arun-Prasad-V Arun-Prasad-V marked this pull request as ready for review December 29, 2023 03:58
@Arun-Prasad-V
Copy link
Contributor Author

LGTM, still draft or ready for merge?

Ready for merge.

@Nir-Az Nir-Az merged commit 11185eb into IntelRealSense:ros2-hkr Dec 29, 2023
5 checks passed
@Nir-Az Nir-Az mentioned this pull request Dec 29, 2023
Closed
@Arun-Prasad-V Arun-Prasad-V deleted the merge_from_dev_to_ros2_hkr_27_12_2023 branch January 31, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Arun-Prasad-V @Nir-Az @SamerKhshiboun @hyunseok-yang @PrasRsRos @gwen2018