Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 215 update alpine #238

Merged
merged 14 commits into from
Mar 6, 2023
Merged

Issue 215 update alpine #238

merged 14 commits into from
Mar 6, 2023

Conversation

nigelgbanks
Copy link
Contributor

@nigelgbanks nigelgbanks commented Aug 31, 2022

This isn't working yet, hoping to have time soonish, but just wanted to push this out on the radar so that work isn't duplicated.

Ready for review.

@seth-shaw-asu
Copy link
Contributor

seth-shaw-asu commented Sep 13, 2022

I think this branch needs to be updated. The first commit has already been integrated into main.

Today I was able to get a Drupal container running PHP 8.1 by starting off with the second commit and then making a few additional changes, mostly to fpm paths ('.txt' extension added so GitHub will upload the file): php81-20220912.patch.txt. See the commit on our local branch: 7612eef.

@seth-shaw-asu
Copy link
Contributor

I did a bit more PHP 8.1 clean-up. See my working branch: https://github.com/asulibraries/isle-buildkit/tree/asu.

@nigelgbanks nigelgbanks force-pushed the issue-215-update-alpine branch 3 times, most recently from b04f7c8 to 5285fa6 Compare November 7, 2022 11:49
@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Nov 7, 2022

When this is finally testable, note the following issue where in fits doesn't get generated on media creation, one can still generate it by manually applying the action and the bug resides out of this repository's hands, so you can ignore that bit.

This is now working... I do not know why.

UPDATE: I now know why see the comment #238 (comment)

@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Nov 9, 2022

In the included test site, there is no search displays setup, that will come at a later date when the following issue is resolved, in the meanwhile you can visit the solr.islandora.dev to confirm documents are actually indexing.

@nigelgbanks
Copy link
Contributor Author

A sample video and image file are included in the test site to confirm that derivatives are being generated.

@nigelgbanks
Copy link
Contributor Author

Automating the installation of Matomo via the console using ExtraTools is just too unstable and flaky that I don't we can rely on it.

@seth-shaw-asu
Copy link
Contributor

Automating the installation of Matomo via the console using ExtraTools is just too unstable and flaky that I don't we can rely on it.

Oh, bother, I ended up not using ExtraTools anyway but forgot to take it out! 🤦‍♂️

@nigelgbanks nigelgbanks force-pushed the issue-215-update-alpine branch 6 times, most recently from 1d470c8 to 179c36c Compare November 21, 2022 07:32
@nigelgbanks nigelgbanks force-pushed the issue-215-update-alpine branch 3 times, most recently from a344582 to 0678b22 Compare November 28, 2022 16:35
@nigelgbanks
Copy link
Contributor Author

@alxp brought this (Islandora-Devops/isle-dc#298) to my attention during the tech call, so I pushed a fix for that we now have a new image for the leptonica package, so we can compile it with its optional open jpeg dependency.

@DonRichards DonRichards self-requested a review February 23, 2023 00:26
Copy link
Member

@DonRichards DonRichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This built for me without an issue and the derivative look correct.

@seth-shaw-asu
Copy link
Contributor

I ran make setup without having pre-commit installed (because the README said I didn't need it) but it errors out before completing. After I installed pre-commit it ran completely and notified me that I hadn't installed jq yet. Now that make, pre-commit, and jq are all updated/installed it completes successfully.

@jefferya
Copy link
Contributor

I swapped the images into a local review environment (LEAF with mods) and ran a few tests. The site loads and PDF's, video/audio and image ingest looks ok. I haven't tried Matomo and Fedora in not in LEAF stack. On bit to maybe highlight is the change log Cantaloupe port change -- this caught me for a bit.

@rosiel
Copy link
Contributor

rosiel commented Feb 24, 2023

Like @seth-shaw-asu, I had to install pre-commit and jq. Now it seems to work. I ran make bake (on mac with homebrew it's gmake bake to avoid warnings caused by the older built-in version of make) and then make certs and make up to launch the test site. I was able to access it and use the site and the IDE (woohoo!)

Aside from potentially listing Cantaloupe in the "Services available" in make up, are we good to proceed?

@nigelgbanks
Copy link
Contributor Author

nigelgbanks commented Feb 24, 2023

I haven't tried Matomo and Fedora in not in LEAF stack. On bit to maybe highlight is the change log Cantaloupe port change -- this caught me for a bit.

I've updated the README, so it is an explicit requirement

@nigelgbanks
Copy link
Contributor Author

Aside from potentially listing Cantaloupe in the "Services available" in make up, are we good to proceed?

I've pushed a commit to add it to the list of services, good catch.

@seth-shaw-asu
Copy link
Contributor

I ran make certs and make up but Microsoft Edge didn't like the certs and won't let me view the site.

@nigelgbanks
Copy link
Contributor Author

I ran make certs and make up but Microsoft Edge didn't like the certs and won't let me view the site.

I'll see what I can do about that mkcert doesn't seem to document any additional steps, and I didn't see anything in their issue queue about Edge. So, we may not be able to support Edge with this...

@nigelgbanks
Copy link
Contributor Author

I ran make certs and make up but Microsoft Edge didn't like the certs and won't let me view the site.

I've pushed a fix for this. In this particular case, mkcert must be run in the host Windows context (i.e. mkcert.exe not under WSL2). As it needs to be able to modify the trust store on Windows to affect the browsers running on Windows. Now the makefile will check if it is running under WSL2 and call the appropriate executable.

@nigelgbanks
Copy link
Contributor Author

@seth-shaw-asu if you test again under Windows be sure to delete the existing certificates you generated under build\certs to ensure that new ones get created.

@nigelgbanks
Copy link
Contributor Author

A number of people have reviewed and tested, so I feel it's safe to merge. If any issues arise, we can raise new tickets, and I'll sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants