quietly find NOAA bufr_query #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRuston
requested review from
Dooruk,
mathomp4,
rajichidamb,
rmclaren and
srherbener
mathomp4
approved these changes
Dec 5, 2025
Dooruk
approved these changes
Dec 5, 2025
rmclaren
approved these changes
Dec 5, 2025
rajichidamb
approved these changes
Dec 5, 2025
Contributor
rajichidamb
left a comment
rajichidamb
left a comment
There was a problem hiding this comment.
Thanks @BenjaminRuston
srherbener
reviewed
Dec 5, 2025
|
|
||
| if( eckit_FOUND AND oops_FOUND AND ioda_FOUND AND bufr_FOUND ) | ||
| set(iodaconv_bufr_query_ENABLED True) | ||
| find_package( bufr_query QUIET ) |
Collaborator
There was a problem hiding this comment.
Seems odd to set iodaconv_bufr_query_ENABLED to True before checking to see if bufr_query is found. Wouldn't it be better to do the find_package for bufr_query right after the find_package for bufr (line 88) and then add "AND bufr_query_FOUND" to the conditional on line 115? The messaging in this if-then-else structure could also be updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to help enable mepo support for NASA GMAO this adds a quiet find of the NOAA bufr_query package
this is a duplicate and replacement PR for:
#1660
Issue(s) addressed
Resolves #1728
Checklist