Skip to content

quietly find NOAA bufr_query #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminRuston merged 2 commits into from
Dec 11, 2025
Merged

quietly find NOAA bufr_query #1730

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffac230
quietly find NESDIS bufr_query
BenjaminRuston Dec 5, 2025
3cc5425
Merge branch 'develop' into feature/mepo-support
BenjaminRuston Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ endif()

if( eckit_FOUND AND oops_FOUND AND ioda_FOUND AND bufr_FOUND )
set(iodaconv_bufr_query_ENABLED True)
find_package( bufr_query QUIET )
Copy link
Collaborator

@srherbener srherbener Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd to set iodaconv_bufr_query_ENABLED to True before checking to see if bufr_query is found. Wouldn't it be better to do the find_package for bufr_query right after the find_package for bufr (line 88) and then add "AND bufr_query_FOUND" to the conditional on line 115? The messaging in this if-then-else structure could also be updated accordingly.

message(STATUS "Found: eckit")
message(STATUS "Found: oops")
message(STATUS "Found: ioda")
Expand Down