Refactor ObsErrors and move factory to UFO#1208
Merged
Conversation
shlyaeva
approved these changes
Dec 3, 2025
shlyaeva
requested review from
Dooruk and
guillaumevernieres
and removed request for
travissluka
Dooruk
approved these changes
Dec 3, 2025
ytremolet
approved these changes
Dec 4, 2025
Contributor
|
@shlyaeva @Dooruk @guillaumevernieres It seems the error is not related to this PR. Ok if I merge once the CI in other repos finishes? |
Contributor
Author
|
The CI failure is most likely due to missing this PR: #1210, this should be good to merge |
Collaborator
|
I've updated this branch, I agree with @ncrossette that the failure was because develop wasn't merged in. OK with me to merge. |
jcsda-bot
pushed a commit
to JCSDA/mpas-jedi
that referenced
this pull request
Dec 8, 2025
## Description Companion to: JCSDA-internal/oops#3115 Removes the now unneeded & removed obsErrorFactory instantiation and changes default ObsError from the oops::ObsErrorDiag to the functionally identical ufo:ObsErrorDiagonal. There are no changes required to the test reference files. ## Issue(s) addressed Resolves: ## Dependencies build-group=JCSDA-internal/oops#3115 build-group=JCSDA-internal/ufo#3900 build-group=JCSDA-internal/fv3-jedi#1437 build-group=JCSDA-internal/soca#1208 LIST OF MODIFIED FILES: M src/mains/mpasEnKF.cc M src/mains/mpasHofX.cc M src/mains/mpasHofX3D.cc M src/mains/mpasVariational.cc M test/covariance/yamls/3dvar.yaml M test/testinput/3denvar_2stream_bumploc.yaml M test/testinput/3denvar_amsua_allsky.yaml M test/testinput/3denvar_amsua_bc.yaml M test/testinput/3denvar_bumploc.yaml M test/testinput/3denvar_dual_resolution.yaml M test/testinput/3dfgat.yaml M test/testinput/3dfgat_cda.yaml M test/testinput/3dfgat_pseudo.yaml M test/testinput/3dhybrid_bumpcov_bumploc.yaml M test/testinput/3dvar.yaml M test/testinput/3dvar_bumpcov.yaml M test/testinput/3dvar_bumpcov_nbam.yaml M test/testinput/3dvar_bumpcov_ropp.yaml M test/testinput/3dvar_bumpcov_rttovcpp.yaml M test/testinput/4denvar_ID.yaml M test/testinput/4denvar_VarBC.yaml M test/testinput/4denvar_VarBC_nonpar.yaml M test/testinput/4denvar_bumploc.yaml M test/testinput/4dfgat.yaml M test/testinput/4dfgat_cda.yaml M test/testinput/4dhybrid_bumpcov_bumploc.yaml M test/testinput/eda_3dhybrid_1.yaml M test/testinput/eda_3dhybrid_2.yaml M test/testinput/eda_3dhybrid_3.yaml M test/testinput/eda_3dhybrid_4.yaml M test/testinput/enshofx_1.yaml M test/testinput/enshofx_2.yaml M test/testinput/enshofx_3.yaml M test/testinput/enshofx_4.yaml M test/testinput/enshofx_5.yaml M test/testinput/letkf_3dloc.yaml M test/testinput/lgetkf.yaml M test/testinput/lgetkf_height_vloc.yaml TESTS CONDUCTED: ran ctests w/spack-stack-1.9.1 --------- Co-authored-by: Yannick Trémolet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to: https://github.com/JCSDA-internal/oops/pull/3115/
Removes the now unneeded & removed obsErrorFactory instantiation and changes default ObsError from the oops::ObsErrorDiag to the functionally identical ufo:ObsErrorDiagonal.
Dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/3115
build-group=https://github.com/JCSDA-internal/ufo/pull/3900
build-group=https://github.com/JCSDA-internal/fv3-jedi/pull/1437
build-group=https://github.com/JCSDA-internal/mpas-jedi/pull/1127