Remove workflow for clang

Jacquwes · Sep 27, 2023 · 188dea6 · 188dea6
1 parent 4525611
commit 188dea6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -25,22 +25,17 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest]
         build_type: [Release]
-        c_compiler: [gcc, clang, cl]
+        c_compiler: [gcc, cl]
         include:
           - os: windows-latest
             c_compiler: cl
             cpp_compiler: cl
           - os: ubuntu-latest
             c_compiler: gcc
             cpp_compiler: g++
-          - os: ubuntu-latest
-            c_compiler: clang
-            cpp_compiler: clang++
         exclude:
           - os: windows-latest
             c_compiler: gcc
-          - os: windows-latest
-            c_compiler: clang
           - os: ubuntu-latest
             c_compiler: cl
 

diff --git a/shared/include/snowflake.h b/shared/include/snowflake.h
@@ -45,10 +45,10 @@ namespace pine
 		bool operator ==(snowflake const& other) const;
 
 		/// @brief Compare a snowflake with an id.
-		bool operator !=(uint64_t other) const;
+		bool operator !=(uint64_t const& other) const;
 
 		/// @brief Compare a snowflake with an id.
-		bool operator ==(uint64_t other) const;
+		bool operator ==(uint64_t const& other) const;
 
 		/// @brief Convert the snowflake to an id.
 		constexpr operator uint64_t() const

diff --git a/shared/src/snowflake.cpp b/shared/src/snowflake.cpp
@@ -48,12 +48,12 @@ namespace pine
 			&& value.sequence == other.value.sequence;
 	}
 
-	bool snowflake::operator != (uint64_t other) const
+	bool snowflake::operator !=(uint64_t const& other) const
 	{
-		return !(static_cast<uint64_t>(*this) == other);
+		return !(*this == other);
 	}
 
-	bool snowflake::operator ==(uint64_t other) const
+	bool snowflake::operator ==(uint64_t const& other) const
 	{
 		return static_cast<uint64_t>(*this) == other;
 	}