multisem wafer 60 and 61 first pass #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(ingestion_ibeammsem): get_xys_sfov_and_paths
docs(ingestion_ibeammsem): type hint and overlook in docstring
…pport for regions
…e no longer symmetrical (still need to break up build_mfov_column_group into smaller functions)
…1 (using xlog data instead)
…are being imported
…dd support for regions
review of PR #16
…r and allow for it to be omitted for single wafer data sets
review of msem_tile_trimmer
…and xlog zero-based SFOV IDs
…nd 'tkagg' which requires the 'tk' interactive framework, as 'headless' is currently running"
…also using blockFactorXY 1 instead of default 8 to avoid OOM with larger 1024,1024,maxZ blocks
…ghbors parameter, and bump up xyNeighborFactor from 0.3 to 0.6 to fix missing match problem for wafer 60 slab 399 MFOVs that have a larger overlap
…rrection code. The basicpy dependency required a much newer pydantic. I updated the pydantic dependency, but needed to remove the fibsem-tools dependency because it limits pydantic versions. We don't need fibsem-tools for multi-SEM, but this will make it more difficult to merge the multisem branch back to the main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pass at changes to handle wafers 60 and 61 using @templiert 's new xlog data and utilities ...