Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#58 navbar header refactoring #63

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

1eecan
Copy link
Contributor

@1eecan 1eecan commented Oct 31, 2023

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

헤더 네브바, 글로벌 스타일을 수정했습니다.

👨‍💻 구현 내용 or 👍 해결 내용

feat: 헤더 수정

feat: navbar 수정

1eecan committed 16 minutes ago
feat: 레이아웃수정

🎯 PR 포인트

📝 참고 사항

❓ 궁금한 점

#58 close

* 헤더,navbar max-width 삭제
* 헤더 title 위치 중간으로 수정
* 헤더 우측 아이콘 styledComponent 통일
* 글로벌스타일 변경
* 헤더 로고 변경
* 헤더 타이틀 일립시스
@1eecan 1eecan added the 긴급 긴급한 수정사항으로 바로 리뷰해 주세요. label Oct 31, 2023
@1eecan 1eecan self-assigned this Oct 31, 2023
@1eecan 1eecan linked an issue Oct 31, 2023 that may be closed by this pull request
@1eecan
Copy link
Contributor Author

1eecan commented Oct 31, 2023

🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

Copy link
Member

@dlwl98 dlwl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1eecan 1eecan merged commit 3f6d078 into dev Oct 31, 2023
@1g2g 1g2g mentioned this pull request Oct 31, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
긴급 긴급한 수정사항으로 바로 리뷰해 주세요.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

하단 navbar, 헤더 리팩터링
3 participants