Address cli bug in spacetime_constructor #50
Conversation
…kage that require any variables that are evaluated (by being within curly braces) with a leading period be wrapped in parentheses like so. Created unit test for new change
✅ Deploy Preview for elastic-lumiere-271348 canceled.
|
| @@ -1,6 +1,7 @@ | |||
| # sfdep 0.2.4 | |||
|
|
|||
| - Dexter Locke is now the maintainer of sfdep | |||
| - updated spacetime_constructor to comply with updates to the cli package. No user-facing changes | |||
There was a problem hiding this comment.
this needs to be under a new version heading since 0.2.4 is released on CRAN. This bug is not in version 0.2.4.
Can you increment the version using usethis::use_version("dev")? Then move this note under the new version heading it will make?
There was a problem hiding this comment.
usethis::use_version("dev") puts "development up top, not the numbers, so I manually put in 0.2.5. Which do you prefer?
Merge branch 'update_0.2.4' of https://github.com/DHLocke/sfdep into update_0.2.4 # Conflicts: # DESCRIPTION
| 0 errors | 0 warnings | 0 note | ||
| Package was archived yesterday, 2023-01-09, despite efforts to address outstanding issues. | ||
|
|
||
| * This release removes myself (Josiah Parry) as the maintainer and makes | ||
| Dexter Locke the new maintainer of sfdep. | ||
| * CRAN has been notified of this in previous correspondence via email | ||
| * Addresses failing noSuggests checks | ||
| Latest submission failed the recursive `noSuggest` check. An example using an imported package (sf) failed because the imported function (sf::read_sf) used a suggested package (tibble suggested by sf). All instances of `sf::read_sf()` have been changed to `sf::st_read()` which, I believe, does not use any suggested packages. |
There was a problem hiding this comment.
please revert changes to reflect what is currently on the main branch.
NEWS.md
Outdated
| - Dexter Locke [@DHLocke] is now the maintainer of sfdep | ||
| - Address failing CRAN checks h/t [@rsbivand](https://github.com/rsbivand) <https://github.com/JosiahParry/sfdep/pull/43> |
There was a problem hiding this comment.
Can you please move these bullets back under 0.2.4 heading and remove - CRAN?
JosiahParry
changed the title
|
It looks like you're adding every file that is shown as being changed and that you might not have pull changes from main before creating a branch. Be sure to check the changes in the files before staging them. You can check the changes by running |
This PR fixes an issue with spacetime_constructor created by an update to the cli package