-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address cli bug in spacetime_constructor #50
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c1ac51
added () in validate_spacetime to complie with changes in the cli pac…
e6a79d2
updated news about cli-fix and created spacetime-constructor test
1513402
Merge branch 'main' into update_0.2.4
DHLocke e806e7e
updateded test for expect_error instaed of expect_snapshot for issue #49
d100283
addressing @JosiahParry's comments to PR#50 attempt
95a91a7
annother attempt to resolve the issues with #49
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
Package: sfdep | ||
Title: Spatial Dependence for Simple Features | ||
|
||
Version: 0.2.4 | ||
Authors@R: c( | ||
person("Josiah", "Parry", , "[email protected]", role = c("aut"), | ||
comment = c(ORCID = "0000-0001-9910-865X")), | ||
person("Dexter", "Locke", 'H', "[email protected]", role = c("aut", "cre"), | ||
comment = c(ORCID = "0000-0003-2704-9720")) | ||
) | ||
|
||
Description: An interface to 'spdep' to integrate with 'sf' objects and the 'tidyverse'. | ||
License: GPL-3 | ||
URL: https://sfdep.josiahparry.com, https://github.com/josiahparry/sfdep | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
## R CMD check results | ||
|
||
0 errors | 0 warnings | 0 note | ||
Package was archived yesterday, 2023-01-09, despite efforts to address outstanding issues. | ||
|
||
* This release removes myself (Josiah Parry) as the maintainer and makes | ||
Dexter Locke the new maintainer of sfdep. | ||
* CRAN has been notified of this in previous correspondence via email | ||
* Addresses failing noSuggests checks | ||
Latest submission failed the recursive `noSuggest` check. An example using an imported package (sf) failed because the imported function (sf::read_sf) used a suggested package (tibble suggested by sf). All instances of `sf::read_sf()` have been changed to `sf::st_read()` which, I believe, does not use any suggested packages. | ||
Comment on lines
-3
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please revert changes to reflect what is currently on the main branch. |
12 changes: 12 additions & 0 deletions
12
tests/testthat/test-spacetime-constructor_cli_update_patch.R
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
test_that("local_g_perm", { | ||
df_fp <- system.file("extdata", "bos-ecometric.csv", package = "sfdep") | ||
geo_fp <- system.file("extdata", "bos-ecometric.geojson", package = "sfdep") | ||
|
||
# read in data | ||
df <- read.csv( | ||
df_fp, colClasses = c("numeric", "character", "integer", "double", "Date") | ||
) | ||
|
||
geo <- sf::st_read(geo_fp) | ||
expect_error(spacetime(df, geo, ".region_id", "year")) | ||
DHLocke marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be under a new version heading since 0.2.4 is released on CRAN. This bug is not in version 0.2.4.
Can you increment the version using
usethis::use_version("dev")
? Then move this note under the new version heading it will make?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usethis::use_version("dev") puts "development up top, not the numbers, so I manually put in 0.2.5. Which do you prefer?