Skip to content

Split parameterized_models.jl (pure move) - #139

Merged
alecloudenback merged 1 commit into
refactor/03-ambiguitiesfrom
refactor/04-split-parametric
Oct 1, 2026
Merged

alecloudenback merged 1 commit into
refactor/03-ambiguitiesfrom
refactor/04-split-parametric

Conversation

@alecloudenback

@alecloudenback alecloudenback commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Merge map (updated 2026-09-29)

Part of the coordinated FinanceCore 2.8, FinanceModels 7.0, ActuaryUtilities 6.0 and MortalityTables 3.0 releases. Merge each stack bottom-up with Create a merge commit, delete each merged branch so GitHub retargets the next PR onto the default branch, and let the retargeted PR's CI finish before merging it.

Order Package PRs, merged left to right Then
1 FinanceCore #56 register 2.8.0
2 FinanceModels #311 → #314 → #295 → #308 → #315 → #316 → #317 → #318 → #319 → #320 → #322 → #323 → #324 → #325 → #326 register 7.0.0
3 ActuaryUtilities #160 → #161 (#160 is a draft, proposed to merge first with #161 rebased onto it; #161 merges after FinanceModels 7.0.0 is registered) register 6.0.0
any MortalityTables #136 → #137 → #138 → #139 → #140 → #141 → #142 → #143 → #144 → #145 → #146 → #147 → #149 → #151 → #148 (independent of the other three) register 3.0.0

This PR: MortalityTables #139, number 4 of 15 (base #138; next #140).


parameterized_models.jl was 959 lines with a natural seam at the ### Generic Functions comment. PRs 5 through 7 rewrite the law catalogue and edit the generic section, so moving the generic section out first keeps those diffs readable.

Changes

  • New src/parametric_interface.jl holds abstract type ParametricMortality end plus the generic section, verbatim.
  • parameterized_models.jl keeps only the law catalogue.
  • Included immediately before the catalogue so the abstract type precedes the structs.

Verified as a pure move with git diff --color-moved=dimmed-zebra: the only non-moved line is the new include.

Testing

  • No test changes. Full suite green.

Stacked on #138 (base branch refactor/03-ambiguities). Merge the stack in order; once the base PR is merged and its branch deleted, GitHub retargets this PR to master.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT

Pure move: the abstract type and the generic-function section of
parameterized_models.jl now live in parametric_interface.jl, which is
included immediately before the catalogue.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.62%. Comparing base (3f69f78) to head (8ab82cf).

Files with missing lines Patch % Lines
src/parametric_interface.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           refactor/03-ambiguities     #139      +/-   ##
===========================================================
+ Coverage                    90.02%   90.62%   +0.59%     
===========================================================
  Files                            8       10       +2     
  Lines                          381      384       +3     
===========================================================
+ Hits                           343      348       +5     
+ Misses                          38       36       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant