Skip to content

Dukes-MacDonald tidy - #146

Merged
alecloudenback merged 1 commit into
masterfrom
refactor/11-dukes-macdonald
Oct 1, 2026
Merged

alecloudenback merged 1 commit into
masterfrom
refactor/11-dukes-macdonald

Conversation

@alecloudenback

@alecloudenback alecloudenback commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Merge map (updated 2026-10-01)

Part of the coordinated FinanceCore 2.8, FinanceModels 7.0, ActuaryUtilities 6.0 and MortalityTables 3.0 releases. Merge each stack bottom-up with Create a merge commit. Automatic branch deletion is on, so after each merge GitHub retargets the next PR onto the default branch: check that its base says master and let its CI finish before merging it.

Order Package Merged Open, merge left to right Then
1 FinanceCore #56 — 2.8.0 registered (2026-09-30)
2 FinanceModels #311, #314, #295, #308, #315, #316 #327 → #317 → #318 → #319 → #320 → #322 → #323 → #324 → #325 → #326 (#315 and #316 were merged into stacked branches, not master; #327 lands them) register 7.0.0
3 ActuaryUtilities — #161 (includes #160's change, so #160 is closed; merges after FinanceModels 7.0.0 is registered) register 6.0.0
any MortalityTables #136, #137, #138, #139, #140, #141 #152 → #142 → #143 → #144 → #145 → #146 → #147 → #149 → #151 → #148 (#138–#141 were merged into stacked branches, not master; #152 lands them. Independent of the other three) register 3.0.0

This PR: MortalityTables #146, number 6 of 10 open (base #145; next #147).


dukes_macdonald.jl imported SelectUltimateTable from the module that was in the middle of defining it, and the import was unused. The three table-adapter methods were the same three lines copied.

Changes

  • The self-import is deleted.
  • One private helper _point_in_scale_and_select(table, issue_age, attained_age); the three table-taking methods are one-liners over it. Docstrings stay on the direct-argument methods.

Testing

  • The existing tests cover both call forms. Full suite green.

Stacked on #145 (base branch refactor/10-exports-docs). Merge the stack in order; once the base PR is merged and its branch deleted, GitHub retargets this PR to master.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (refactor/10-exports-docs@521af16). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             refactor/10-exports-docs     #146   +/-   ##
===========================================================
  Coverage                            ?   90.73%           
===========================================================
  Files                               ?       10           
  Lines                               ?      367           
  Branches                            ?        0           
===========================================================
  Hits                                ?      333           
  Misses                              ?       34           
  Partials                            ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Drop the unused self-import of SelectUltimateTable and route the three
table-taking methods through one helper that reads the point-in-scale
and select rates from the table.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JFnc6pvofuNXTW2xdCcewT
@alecloudenback
alecloudenback force-pushed the refactor/11-dukes-macdonald branch from 1fd2081 to b68fe9e Compare September 24, 2026 22:50
@alecloudenback
alecloudenback force-pushed the refactor/10-exports-docs branch from 521af16 to 6159948 Compare September 24, 2026 22:50
This was referenced Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant