Skip to content

Fix java:S5998 & java:S8786: regex reliability issues in XPathFunctionsGenerator #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lordrip merged 2 commits into from
Sep 18, 2026
Merged

Fix java:S5998 & java:S8786: regex reliability issues in XPathFunctionsGenerator #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c37d8c7
fix(sonar): resolve java:S5998 regex stack overflow in buildSummaryMap
lordrip Sep 18, 2026
3bab671
fix(sonar): resolve java:S8786 non-linear backtracking in buildFuncti…
lordrip Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/io/kaoto/camelcatalog/generator/xslt/XPathFunctionsGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ Map<String, String> buildSummaryMap(String rawXml) {

String funcXml = rawXml.substring(startPos, endPos);
Pattern summaryPattern = Pattern.compile(
"<fos:summary>([^<]*(?:<(?!/fos:summary>)[^<]*)*)</fos:summary>");
"<fos:summary>([^<]*+(?:<(?!/fos:summary>)[^<]*+)*+)</fos:summary>");
Matcher summaryMatcher = summaryPattern.matcher(funcXml);
if (summaryMatcher.find()) {
String key = prefixMatch.group(1) + ":" + nameMatch.group(1);
Expand All @@ -497,7 +497,7 @@ record Event(int pos, String type, String level, String id, String prefix, Strin

List<Event> events = new ArrayList<>();

Pattern divOpenPattern = Pattern.compile("<(div[1-3])\\s[^>]*?id=\"([^\"]+)\"[^>]*>");
Pattern divOpenPattern = Pattern.compile("<(div[1-3])\\s(?:[^>i]|i(?!d=))*+id=\"([^\"]+)\"[^>]*+>");
Matcher divOpenMatcher = divOpenPattern.matcher(specXml);
while (divOpenMatcher.find()) {
events.add(new Event(divOpenMatcher.start(), "open", divOpenMatcher.group(1),
Expand Down
Loading