Additional JDK25 and Quarkus 3.28.1 whitelists #371
Conversation
|
@jerboaa Some more whitelists; GHA does not show it because GHA does not run the full suite. |
| if ((UsedVersion.getVersion(inContainer).compareTo(Version.create(25, 0, 0)) >= 0)) { | ||
| // https://github.com/quarkusio/quarkus/issues/47769 | ||
| p.add(Pattern.compile(".*to use the thread-local-reset capability on Java 24 or later.*")); | ||
| p.add(Pattern.compile(".*Could not initialize class org.jboss.threads.JDKSpecific.*")); | ||
| } |
There was a problem hiding this comment.
Where do we see those? A better fix would be to run native-image with -J--add-opens=java.base/java.lang=ALL-UNNAMED since we know it's needed for a newly generated quarkus app. This avoids not seeing them when we actually don't expect it.
There was a problem hiding this comment.
@jerboaa Quarkus app: https://github.com/Karm/mandrel-integration-tests/tree/master/apps/quarkus-mp-orm-dbs-awt
So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place fir the TS to add it. I assumed it's gonna be fixed with your Q update in the comment.
There was a problem hiding this comment.
So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place for the TS to add it
I think we should fix it that way. This ensures we don't get the thread-local-reset warning even when running on Mandrel 24+ for quarkus-pm-orm-dbs-awt, but for no other app. The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.
I assumed it's gonna be fixed with your Q update in the comment.
quarkusio/quarkus#47637 fixed it for quarkus-core. Since this is an app generated separately, it'll need the add-opens on launch separately I think. Unless my understanding isn't correct and I miss something.
There was a problem hiding this comment.
The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.
Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT
So it's really a matter of either adding the -J--add-opens to the command line or whitelisting it here.
I am O.K. with adding it to the app's command line though, so I'll refactor it...
There was a problem hiding this comment.
The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.
Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT
Ah, right. My bad.
No description provided.