Skip to content

Additional JDK25 and Quarkus 3.28.1 whitelists #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Additional JDK25 and Quarkus 3.28.1 whitelists #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions testsuite/src/it/java/org/graalvm/tests/integration/utils/WhitelistLogLines.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,16 @@ public Pattern[] get(boolean inContainer) {
p.add(Pattern.compile(".*sun.misc.Unsafe::objectFieldOffset has been called by org.jboss.threads.JBossExecutors.*"));
p.add(Pattern.compile(".*java.lang.System::load has been called by com.sun.jna.Native in.*net/java/dev/jna.*"));
}
if (QUARKUS_VERSION.compareTo(new QuarkusVersion("3.28.1")) >= 0 || QUARKUS_VERSION.isSnapshot()) {
p.add(Pattern.compile(".*JDBC fetch size: undefined/unknown.*"));
p.add(Pattern.compile(".*Pool: undefined/unknown.*"));
p.add(Pattern.compile(".*catalog/schema: unknown/unknown.*"));
}
}
if ((UsedVersion.getVersion(inContainer).compareTo(Version.create(25, 0, 0)) >= 0)) {
// https://github.com/quarkusio/quarkus/issues/47769
p.add(Pattern.compile(".*to use the thread-local-reset capability on Java 24 or later.*"));
p.add(Pattern.compile(".*Could not initialize class org.jboss.threads.JDKSpecific.*"));
}
Comment on lines +309 to 313
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we see those? A better fix would be to run native-image with -J--add-opens=java.base/java.lang=ALL-UNNAMED since we know it's needed for a newly generated quarkus app. This avoids not seeing them when we actually don't expect it.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerboaa Quarkus app: https://github.com/Karm/mandrel-integration-tests/tree/master/apps/quarkus-mp-orm-dbs-awt

So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place fir the TS to add it. I assumed it's gonna be fixed with your Q update in the comment.

Copy link
Collaborator

@jerboaa jerboaa Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place for the TS to add it

I think we should fix it that way. This ensures we don't get the thread-local-reset warning even when running on Mandrel 24+ for quarkus-pm-orm-dbs-awt, but for no other app. The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

I assumed it's gonna be fixed with your Q update in the comment.

quarkusio/quarkus#47637 fixed it for quarkus-core. Since this is an app generated separately, it'll need the add-opens on launch separately I think. Unless my understanding isn't correct and I miss something.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT

So it's really a matter of either adding the -J--add-opens to the command line or whitelisting it here.

I am O.K. with adding it to the app's command line though, so I'll refactor it...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT

Ah, right. My bad.

return p.toArray(new Pattern[0]);
}
Expand Down