Numeric-Input: Extract validation from scorer #1882
Merged
+16
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6a26500) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1882If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1882 |
|
Size Change: -9 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
jeremywiebe
changed the title
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
approved these changes
Nov 20, 2024
packages/perseus/src/widgets/numeric-input/validate-numeric-input.ts
Outdated
Show resolved
Hide resolved
Comment on lines
19
to
21
| const mockValidator = jest | ||
| .spyOn(NumericInputValidator, "default") | ||
| .mockReturnValue(null); |
There was a problem hiding this comment.
Why do we need to mock the validator?
There was a problem hiding this comment.
I've changed my mind. The numeric-input allows an empty string to be correct for answers that have coefficient set to true.
// A coefficient style number allows the student to use - for -1 and an empty string to mean 1.
coefficient: boolean;
I'm going to revert the validator entirely and delete it as marking an empty string as "invalid" is going to cause false-negative results.
…put.ts Co-authored-by: Matthew <[email protected]>
jeremywiebe
force-pushed
the
jer/validate-numeric-input
branch
from
7a5ac63
to
6a26500
Compare
jeremywiebe
changed the base branch from
main
to
release/server-side-scoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR extracts validation from the
numeric-input's scorer function. In reality, it's an empty function, but it follows our conventions for having the scorer call a validator first. I've created the standard tests to ensure that scorer calls the validator.Issue: LEMS-2607
Test plan:
yarn testyarn typecheck