Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric-Input: Extract validation from scorer #1882

Merged
merged 5 commits into from
Nov 21, 2024
+16 −11
Merged

Numeric-Input: Extract validation from scorer #1882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d5bef7
Create numeric-input validator and tests even though its empty
jeremywiebe Nov 19, 2024
82cfce6
Changeset
jeremywiebe Nov 19, 2024
7992189
Add validation for empty user input
jeremywiebe Nov 19, 2024
33a71ff
Update packages/perseus/src/widgets/numeric-input/validate-numeric-in…
jeremywiebe Nov 20, 2024
6a26500
Remove empty numeric-input validator
jeremywiebe Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-avocados-accept.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": minor
---

Introduces a validation function for the numeric-input widget (extracted from numeric-input scoring function).
20 changes: 10 additions & 10 deletions packages/perseus/src/widgets/numeric-input/score-numeric-input.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ describe("static function validate", () => {
coefficient: true,
};

const useInput = {
const userInput = {
currentValue: "1",
} as const;

const score = scoreNumericInput(useInput, rubric, mockStrings);
const score = scoreNumericInput(userInput, rubric, mockStrings);

expect(score).toHaveBeenAnsweredCorrectly();
});
Expand All @@ -52,11 +52,11 @@ describe("static function validate", () => {
coefficient: true,
};

const useInput = {
const userInput = {
currentValue: "sadasdfas",
} as const;

const score = scoreNumericInput(useInput, rubric, mockStrings);
const score = scoreNumericInput(userInput, rubric, mockStrings);

expect(score).toHaveInvalidInput(
"We could not understand your answer. Please check your answer for extra text or symbols.",
Expand Down Expand Up @@ -143,11 +143,11 @@ describe("static function validate", () => {
coefficient: true,
};

const useInput = {
const userInput = {
currentValue: "1.0",
} as const;

const score = scoreNumericInput(useInput, rubric, mockStrings);
const score = scoreNumericInput(userInput, rubric, mockStrings);

expect(score).toHaveBeenAnsweredCorrectly();
});
Expand All @@ -167,11 +167,11 @@ describe("static function validate", () => {
coefficient: true,
};

const useInput = {
const userInput = {
currentValue: "1.3",
} as const;

const score = scoreNumericInput(useInput, rubric, mockStrings);
const score = scoreNumericInput(userInput, rubric, mockStrings);

expect(score).toHaveBeenAnsweredIncorrectly();
});
Expand All @@ -191,11 +191,11 @@ describe("static function validate", () => {
coefficient: true,
};

const useInput = {
const userInput = {
currentValue: "1.12",
} as const;

const score = scoreNumericInput(useInput, rubric, mockStrings);
const score = scoreNumericInput(userInput, rubric, mockStrings);

expect(score).toHaveBeenAnsweredCorrectly();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/perseus/src/widgets/numeric-input/score-numeric-input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function maybeParsePercentInput(
return value / 100;
}

// Otherwise, we return input valuåe (number) stripped of the "%".
// Otherwise, we return input value (number) stripped of the "%".
return value;
}

Expand Down