[SR] Add comment about creating translation tickets #1894
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment to the `strings.ts` file so it's easy to keep track of which strings will need to be finalized before translation tickets are made. We want to wait until all the interactive element strings for interactive graph have been written and confirmed before creating their respective translation tickets. Issue: https://khanacademy.atlassian.net/browse/LEMS-2660 Test plan: N/A
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c29535a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1894If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1894 |
|
Size Change: +110 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
nishasy
commented
Nov 21, 2024
| srPointAtCoordinates: { | ||
| context: "Screenreader-accessible description of a point on a graph", | ||
| message: "Point %(num)s at %(x)s comma %(y)s", | ||
| }, | ||
| srInteractiveElements: "Interactive elements: %(elements)s", | ||
| srNoInteractiveElements: "No interactive elements", | ||
| }; |
There was a problem hiding this comment.
would it be better to just not put the strings here at all? I can remove the strings from this section so that they don't get auto-flagged for translations, and I can move this comment up to the PerseusStrings section instead so we can remember to bring them down here later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a comment to the
strings.tsfile so it's easyto keep track of which strings will need to be
finalized before translation tickets are made.
We want to wait until all the interactive element
strings for interactive graph have been written
and confirmed before creating their respective
translation tickets.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2660
Test plan:
N/A