Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR] Add comment about creating translation tickets #1894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

[SR] Add comment about creating translation tickets #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-spies-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

[SR] Add comment about making translation tickets
9 changes: 7 additions & 2 deletions packages/perseus/src/strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,17 @@ export const strings: {
graphKeyboardPrompt: "Press Shift + Enter to interact with the graph",
closePolygon: "Close shape",
openPolygon: "Re-open shape",
srInteractiveElements: "Interactive elements: %(elements)s",
srNoInteractiveElements: "No interactive elements",

// TODO(LEMS-2660): The following strings are ones that will need
// translation tickets after all interactive graph SR strings have
// been finalized. Remove this comment after the tickets have been
// created.
srPointAtCoordinates: {
context: "Screenreader-accessible description of a point on a graph",
message: "Point %(num)s at %(x)s comma %(y)s",
},
srInteractiveElements: "Interactive elements: %(elements)s",
srNoInteractiveElements: "No interactive elements",
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to just not put the strings here at all? I can remove the strings from this section so that they don't get auto-flagged for translations, and I can move this comment up to the PerseusStrings section instead so we can remember to bring them down here later?


/**
Expand Down