Fixup cl_khr_command_buffer after extension spec unification #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
changed the title
EwanC
added
the
cl_khr_command_buffer
bashbaug
reviewed
Mar 25, 2024
bashbaug
approved these changes
Mar 26, 2024
|
@KhronosWebservices the CLA bot seems to be stuck here too, can you help? |
Looking more closely at this now. |
After PR KhronosGroup#950 merged the cl_khr_command_buffer spec needs updated in a couple of places: * Error around _num_queues_ to `clCreateCommandBufferKHR` should be in terms of `cl_khr_command_buffer_multi_device`. * "New Structure" heading can be deleted as these are listed under "New Types" * Typos in rendering of some types
EwanC
force-pushed
the
command_buffer_fixups
branch
from
92cb7d8
to
fc1c6e8
Compare
|
@bashbaug Did the cla-assistant resolve on its own? From what I can tell this is a problem at the cla-assistant end, as our tokens appeared to still be usable and lots of calls left. |
There was a merge conflict after another PR merged first, I pushed a rebase to resolve it and when the CI re-ran the issue disappeared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #950 merged the cl_khr_command_buffer spec needs updated in a couple of places:
clCreateCommandBufferKHRshould be in terms ofcl_khr_command_buffer_multi_device.