Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): simplify loading images #3741

Merged
merged 1 commit into from
Mar 16, 2023
Merged

chore(e2e): simplify loading images #3741

merged 1 commit into from
Mar 16, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Mar 16, 2023

What this PR does / why we need it:

Instead of depending on both TEST_KONG_CONTROLLER_IMAGE_OVERRIDE and TEST_KONG_CONTROLLER_IMAGE_LOAD when patching the controller image, let's just always use TEST_KONG_CONTROLLER_IMAGE_OVERRIDE.

Instead of using TEST_KONG_CONTROLLER_IMAGE_LOAD, let's have a boolean TEST_KONG_LOAD_IMAGES that will tell whether to load overridden images to the cluster or not.

E2E tests run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4437636384

@czeslavo czeslavo marked this pull request as ready for review March 16, 2023 13:45
@czeslavo czeslavo requested a review from a team as a code owner March 16, 2023 13:45
@czeslavo czeslavo requested a review from pmalek March 16, 2023 14:05
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.1 🎉

Comparison is base (923cdf3) 73.5% compared to head (08966ae) 73.6%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3741     +/-   ##
=======================================
+ Coverage   73.5%   73.6%   +0.1%     
=======================================
  Files        133     133             
  Lines      15828   15828             
=======================================
+ Hits       11642   11658     +16     
+ Misses      3425    3413     -12     
+ Partials     761     757      -4     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo merged commit 50a4c3f into main Mar 16, 2023
@czeslavo czeslavo deleted the make-load-image-boolean branch March 16, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants