chore(e2e): simplify loading images #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
make-load-image-boolean
branch
from
03a5ca6
to
08966ae
Compare
pmalek
reviewed
Mar 16, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
=======================================
+ Coverage 73.5% 73.6% +0.1%
=======================================
Files 133 133
Lines 15828 15828
=======================================
+ Hits 11642 11658 +16
+ Misses 3425 3413 -12
+ Partials 761 757 -4 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pmalek
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of depending on both
TEST_KONG_CONTROLLER_IMAGE_OVERRIDEandTEST_KONG_CONTROLLER_IMAGE_LOADwhen patching the controller image, let's just always useTEST_KONG_CONTROLLER_IMAGE_OVERRIDE.Instead of using
TEST_KONG_CONTROLLER_IMAGE_LOAD, let's have a booleanTEST_KONG_LOAD_IMAGESthat will tell whether to load overridden images to the cluster or not.E2E tests run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4437636384