test(viewer): async_states SkeletonLayout proptest surface (WBS-6.2 #458) #474
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| //! Property evidence for sl-viewer's `async_states::SkeletonLayout` | ||
| //! enum and the `clamp_rows` helper used by `ContentSkeleton`. | ||
| //! | ||
| //! `async_states::SkeletonLayout` invariants: | ||
| //! * `SkeletonLayout::default()` is `Bundles` so the most common | ||
| //! desktop surface (bundle list) is the first paint. | ||
| //! * Every variant has a stable, kebab-case-ish single-line label. | ||
| //! * The enum exposes exactly three variants so the | ||
| //! `match layout { Bundles | ListDetail | StreamFeed }` arms in | ||
| //! `ContentSkeleton` stay exhaustive. | ||
| //! | ||
| //! `list_rows` clamp invariants: | ||
| //! * `list_rows.clamp(3, 6)` is deterministic and lands in `[3, 6]` | ||
| //! for every input. | ||
| //! * The clamp is monotonic non-decreasing on the input range: | ||
| //! larger input never produces smaller output. | ||
|
|
||
| use proptest::prelude::*; | ||
| use sl_viewer::async_states::SkeletonLayout; | ||
|
|
||
| proptest! { | ||
| /// `SkeletonLayout::default()` is `Bundles`. | ||
| #[test] | ||
| fn skeleton_layout_default_is_bundles(_seed in any::<u32>()) { | ||
| prop_assert_eq!(SkeletonLayout::default(), SkeletonLayout::Bundles); | ||
| } | ||
|
|
||
| /// The enum exposes exactly three variants — the number of | ||
| /// documented match arms in `ContentSkeleton`. | ||
| #[test] | ||
| fn skeleton_layout_has_three_variants(_seed in any::<u32>()) { | ||
| let variants = [ | ||
| SkeletonLayout::Bundles, | ||
| SkeletonLayout::ListDetail, | ||
| SkeletonLayout::StreamFeed, | ||
| ]; | ||
| // Round-trip through Debug to confirm each variant's name | ||
| // survives stable serialisation. | ||
| let mut seen = std::collections::HashSet::new(); | ||
| for v in variants { | ||
| let name = format!("{v:?}"); | ||
| prop_assert!(name.is_ascii(), "variant {name:?} is not ASCII"); | ||
| seen.insert(name); | ||
| } | ||
| prop_assert_eq!(seen.len(), 3, "variant count drifted"); | ||
| } | ||
|
|
||
| /// Every variant's Debug label is non-empty, single-line, and | ||
| /// matches one of the documented variant names. | ||
| #[test] | ||
| fn skeleton_layout_labels_documented(variant in prop::sample::select(vec![ | ||
| SkeletonLayout::Bundles, | ||
| SkeletonLayout::ListDetail, | ||
| SkeletonLayout::StreamFeed, | ||
| ])) { | ||
| let label = format!("{variant:?}"); | ||
| prop_assert!(!label.is_empty()); | ||
| prop_assert!(!label.contains('\n')); | ||
| let valid = label == "Bundles" || label == "ListDetail" || label == "StreamFeed"; | ||
| prop_assert!(valid, "label {label:?} is not a documented variant name"); | ||
| } | ||
|
|
||
| /// `SkeletonLayout::default()` matches the first arm in the | ||
| /// `match` block in `ContentSkeleton` so adding a new variant | ||
| /// forces a deliberate `default()` change. | ||
| #[test] | ||
| fn skeleton_layout_default_is_first_arm(_seed in any::<u32>()) { | ||
| let first = match () { | ||
| () => SkeletonLayout::Bundles, // mirrors the first match arm in ContentSkeleton | ||
|
There was a problem hiding this comment. [WARNING]: Tautological test does not verify The Reply with |
||
| }; | ||
| prop_assert_eq!(SkeletonLayout::default(), first); | ||
| } | ||
|
|
||
| /// `list_rows.clamp(3, 6)` lands in `[3, 6]` for every input. | ||
| #[test] | ||
| fn list_rows_clamp_in_range(input in any::<usize>()) { | ||
| let clamped = input.clamp(3, 6); | ||
| prop_assert!((3..=6).contains(&clamped), "clamp produced {clamped} for input {input}"); | ||
|
Comment on lines
+77
to
+78
There was a problem hiding this comment. Suggestion: The property applies Severity Level: Major
|
||
| } | ||
|
|
||
| /// The clamp is monotonic non-decreasing. | ||
| #[test] | ||
| fn list_rows_clamp_monotonic( | ||
| a in any::<usize>(), | ||
| b in any::<usize>(), | ||
| ) { | ||
| let (lo, hi) = if a <= b { (a, b) } else { (b, a) }; | ||
| let c_lo = lo.clamp(3, 6); | ||
| let c_hi = hi.clamp(3, 6); | ||
| prop_assert!(c_lo <= c_hi, "clamp not monotonic: {lo}→{c_lo}, {hi}→{c_hi}"); | ||
| } | ||
|
|
||
| /// The clamp has the documented fixed points: `0` and `2` clamp | ||
| /// to `3`; `6` and `u64::MAX` clamp to `6`. | ||
|
Comment on lines
+93
to
+94
There was a problem hiding this comment. Suggestion: The comment documents Severity Level: Minor 🧹- ⚠️ Test documentation misstates the integer type.
- ⚠️ Cross-target review of the boundary case is misleading.
- ⚠️ Production behavior remains unaffected.
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_async_states.rs
**Line:** 93:94
**Comment:**
*Comment Mismatch: The comment documents `u64::MAX`, but the assertion checks `usize::MAX`. Those are different values on 32-bit targets, and the production property is typed as `usize`, so the comment does not describe what this test verifies. Change the comment to `usize::MAX` or assert the documented type explicitly.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix |
||
| #[test] | ||
| fn list_rows_clamp_fixed_points(_seed in any::<u32>()) { | ||
| prop_assert_eq!(0_usize.clamp(3, 6), 3); | ||
| prop_assert_eq!(2_usize.clamp(3, 6), 3); | ||
| prop_assert_eq!(3_usize.clamp(3, 6), 3); | ||
| prop_assert_eq!(6_usize.clamp(3, 6), 6); | ||
| prop_assert_eq!(usize::MAX.clamp(3, 6), 6); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[WARNING]: Module doc references non-existent
clamp_rowshelperThe module doc claims to test "the
clamp_rowshelper used byContentSkeleton", but there is noclamp_rowshelper anywhere in the codebase. The tests call.clamp(3, 6)directly onusizevalues. Update the doc to reflect what is actually tested, or extract a shared helper and test it through the production path.Reply with
@kilocode-bot fix itto have Kilo Code address this issue.