test(viewer): async_states SkeletonLayout proptest surface (WBS-6.2 #458) - #474
test(viewer): async_states SkeletonLayout proptest surface (WBS-6.2 #458)#474KooshaPari wants to merge 1 commit into
Conversation
) Adds crates/sl-viewer/tests/properties_viewer_async_states.rs with 7 proptest properties pinning the async_states SSOT: * SkeletonLayout::default() is Bundles. * SkeletonLayout exposes exactly three variants (Bundles, ListDetail, StreamFeed). * Every variant's Debug label is non-empty, single-line, and matches one of the documented names. * SkeletonLayout::default() matches the first arm in the match block in ContentSkeleton. * list_rows.clamp(3, 6) lands in [3, 6] for every input. * The clamp is monotonic non-decreasing. * The clamp has the documented fixed points (0/2 -> 3, 6/MAX -> 6). Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 8 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| let clamped = input.clamp(3, 6); | ||
| prop_assert!((3..=6).contains(&clamped), "clamp produced {clamped} for input {input}"); |
There was a problem hiding this comment.
Suggestion: The property applies clamp directly to its input rather than invoking ContentSkeleton or a shared helper. Consequently, the test passes even if production stops using the clamped value, applies it only to some layouts, or renders a different number of rows. Test the production rendering path or extract and test the actual shared helper. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Live-feed skeleton row counts can regress undetected.
- ⚠️ Replay loading skeleton row counts can regress undetected.
- ⚠️ Search loading skeleton row counts can regress undetected.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_async_states.rs
**Line:** 77:78
**Comment:**
*Incomplete Implementation: The property applies `clamp` directly to its input rather than invoking `ContentSkeleton` or a shared helper. Consequently, the test passes even if production stops using the clamped value, applies it only to some layouts, or renders a different number of rows. Test the production rendering path or extract and test the actual shared helper.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| /// The clamp has the documented fixed points: `0` and `2` clamp | ||
| /// to `3`; `6` and `u64::MAX` clamp to `6`. |
There was a problem hiding this comment.
Suggestion: The comment documents u64::MAX, but the assertion checks usize::MAX. Those are different values on 32-bit targets, and the production property is typed as usize, so the comment does not describe what this test verifies. Change the comment to usize::MAX or assert the documented type explicitly. [comment mismatch]
Severity Level: Minor 🧹
- ⚠️ Test documentation misstates the integer type.
- ⚠️ Cross-target review of the boundary case is misleading.
- ⚠️ Production behavior remains unaffected.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_async_states.rs
**Line:** 93:94
**Comment:**
*Comment Mismatch: The comment documents `u64::MAX`, but the assertion checks `usize::MAX`. Those are different values on 32-bit targets, and the production property is typed as `usize`, so the comment does not describe what this test verifies. Change the comment to `usize::MAX` or assert the documented type explicitly.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| @@ -0,0 +1,103 @@ | |||
| //! Property evidence for sl-viewer's `async_states::SkeletonLayout` | |||
| //! enum and the `clamp_rows` helper used by `ContentSkeleton`. | |||
There was a problem hiding this comment.
[WARNING]: Module doc references non-existent clamp_rows helper
The module doc claims to test "the clamp_rows helper used by ContentSkeleton", but there is no clamp_rows helper anywhere in the codebase. The tests call .clamp(3, 6) directly on usize values. Update the doc to reflect what is actually tested, or extract a shared helper and test it through the production path.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| #[test] | ||
| fn skeleton_layout_default_is_first_arm(_seed in any::<u32>()) { | ||
| let first = match () { | ||
| () => SkeletonLayout::Bundles, // mirrors the first match arm in ContentSkeleton |
There was a problem hiding this comment.
[WARNING]: Tautological test does not verify ContentSkeleton
The match () { () => SkeletonLayout::Bundles } expression always evaluates to SkeletonLayout::Bundles regardless of ContentSkeleton. This test is functionally identical to skeleton_layout_default_is_bundles and gives false confidence that default() matches the first arm in ContentSkeleton. Either inspect ContentSkeleton directly, or remove this redundant test.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 90.7K · Output: 11.3K · Cached: 320.1K |
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_async_states.rswith 7 proptest properties pinning theasync_states::SkeletonLayoutenum andlist_rows.clamp(3, 6)SSOT (WBS-6.2 #458).SkeletonLayout(4 properties)SkeletonLayout::default()isBundles.SkeletonLayoutexposes exactly three variants (Bundles,ListDetail,StreamFeed).Debuglabel is non-empty, single-line, and matches one of the documented names.SkeletonLayout::default()matches the first arm in thematchblock inContentSkeleton.list_rows.clamp(3, 6)(3 properties)[3, 6]for every input.0/2→3,6/usize::MAX→6).Validation
cargo test -p sl-viewer --test properties_viewer_async_states --features "desktop parquet" --locked— 7 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongaincrates/sl-viewer/tests/properties_viewer_async_states.rs. CHANGELOG Unreleased documents the new surface.CodeAnt-AI Description
Add property coverage for viewer loading layouts and skeleton row limits
What Changed
Impact
✅ Fewer viewer loading-layout regressions✅ Consistent skeleton row counts✅ Clearer property-test coverage💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.