Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dataset #68

Merged
merged 30 commits into from
Aug 29, 2023
Merged

Improved dataset #68

merged 30 commits into from
Aug 29, 2023

Conversation

YohannPerron
Copy link
Contributor

@YohannPerron YohannPerron commented Jul 21, 2023

This PR offers a unified interface for all dataset. It implement a version of the simulated dataset compatible with the new data format and a semi-measured dateset with projection of the original images to object plane.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

@YohannPerron YohannPerron marked this pull request as ready for review July 26, 2023 15:08
lensless/utils/dataset.py Outdated Show resolved Hide resolved
lensless/utils/dataset.py Outdated Show resolved Hide resolved
lensless/utils/dataset.py Outdated Show resolved Hide resolved
@ebezzam ebezzam merged commit bba42c0 into LCAV:main Aug 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants