App cleanup and new tests #1
Conversation
tdejoigny-ledger
force-pushed
the
tdj/new_tests
branch
11 times, most recently
from
9e4e504
to
1ad6574
Compare
tdejoigny-ledger
force-pushed
the
tdj/new_tests
branch
from
1ad6574
to
a079564
Compare
tdejoigny-ledger
requested review from
nroggeman-ledger and
cedelavergne-ledger
src/ui/menu_nbgl.c
Outdated
| @@ -146,13 +154,16 @@ void ui_menu_main(void) { | |||
| switches[DUMMY_SWITCH_2_ID].tuneId = TUNE_TAP_CASUAL; | |||
| #endif | |||
|
|
|||
| homeAction.callback = (nbgl_callback_t) ui_display_review; | |||
There was a problem hiding this comment.
This callback type should be:
typedef void (*nbgl_callback_t)(void),
but the function ui_display_review has an input parameter, which is not good!
There was a problem hiding this comment.
It's true, but it's temporary; this button will launch a page to run flows in a standalone manner.
There was a problem hiding this comment.
I am not fan... Its error prone, even if in this exact situation, it will work.
Better to declare a function with correct prototype, and then call the targeted one without extra parameters...
src/ui/menu_nbgl.c
Outdated
| @@ -146,13 +154,16 @@ void ui_menu_main(void) { | |||
| switches[DUMMY_SWITCH_2_ID].tuneId = TUNE_TAP_CASUAL; | |||
| #endif | |||
|
|
|||
| homeAction.callback = (nbgl_callback_t) ui_display_review; | |||
There was a problem hiding this comment.
I am not fan... Its error prone, even if in this exact situation, it will work.
Better to declare a function with correct prototype, and then call the targeted one without extra parameters...
No description provided.