Skip to content

chore: change slack channel to helm doc upgrade notify workflow - #641

Merged
guimoreirar merged 1 commit into
developfrom
chore/doc-helm-ops-team
Aug 4, 2026
Merged

chore: change slack channel to helm doc upgrade notify workflow#641
guimoreirar merged 1 commit into
developfrom
chore/doc-helm-ops-team

Conversation

@guimoreirar

Copy link
Copy Markdown
Member
Lerian

GitHub Actions Shared Workflows


Description

Type of Change

  • feat: New workflow or new input/output/step in an existing workflow
  • fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
  • perf: Performance improvement (e.g. caching, parallelism, reduced steps)
  • refactor: Internal restructuring with no behavior change
  • docs: Documentation only (README, docs/, inline comments)
  • ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
  • chore: Dependency bumps, config updates, maintenance
  • test: Adding or updating tests
  • BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @this-branch or the beta tag
  • Verified all existing inputs still work with default values
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Caller repo / workflow run:

Related Issues

Closes #

@guimoreirar guimoreirar self-assigned this Aug 4, 2026
@guimoreirar
guimoreirar requested a review from a team as a code owner August 4, 2026 17:00
@guimoreirar
guimoreirar changed the base branch from main to develop August 4, 2026 17:01
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

  • Bug Fixes
    • Updated Helm upgrade documentation workflow notifications to use the correct operations Slack channel.
    • Renamed the workflow’s Slack channel secret to align with the updated configuration.

Walkthrough

The workflow file renames the Slack notification secret from SLACK_CHANNEL_DEVOPS to SLACK_CHANNEL_OPS. The change applies to the secret declaration and to the input passed to the Helm upgrade documentation action.

Changes

Slack Channel Secret Rename

Layer / File(s) Summary
Secret rename in workflow
.github/workflows/helm-upgrade-doc.yml
The declared optional secret changes from SLACK_CHANNEL_DEVOPS to SLACK_CHANNEL_OPS. The action input for Slack notification uses the same renamed secret. Callers must update the secret name in their repository or organization settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bedatty

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description uses the required template but leaves the Description section and Type of Change section blank. The Description field is critical for understanding the rationale and scope of the change. Complete the Description section with a summary of the change and affected workflows. Select the appropriate Type of Change checkbox (chore).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the main change: renaming a Slack channel constant in the Helm upgrade documentation workflow. It accurately reflects the core modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/doc-helm-ops-team

Comment @coderabbitai help to get the list of available commands.

@lerian-studio

Copy link
Copy Markdown
Contributor

⚠️ Invalid Source Branch

Pull requests to main can only come from:

  • develop
  • hotfix/*

Your source branch: chore/doc-helm-ops-team

Please change the base branch or create a PR from an allowed branch.

@lerian-studio

lerian-studio commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio lerian-studio added size/XS PR changes < 50 lines workflow Changes to one or more reusable workflow files labels Aug 4, 2026
@lerian-studio

lerian-studio commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint 1 file(s) ✅ success
Pinned Actions 1 file(s) ✅ success
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check 1 file(s) ✅ success
README Check 1 file(s) ✅ success
Composite Schema no changes ⏭️ skipped
Deployment Matrix no changes ⏭️ skipped

🔍 View full scan logs

@lerian-studio

lerian-studio commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🛡️ CodeQL Analysis Results

Languages analyzed: actions

✅ No security issues found.


🔍 View full scan logs | 🛡️ Security tab

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/helm-upgrade-doc.yml:
- Line 61: Update the workflow_call secret declarations around SLACK_CHANNEL_OPS
to retain both SLACK_CHANNEL_OPS and the legacy SLACK_CHANNEL_DEVOPS secret,
then pass SLACK_CHANNEL_OPS preferentially with SLACK_CHANNEL_DEVOPS as the
fallback when setting the slack-channel composite-action input.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 866f2739-0f70-48aa-a3f4-30ccaa7f2bed

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe6462 and 6d0d947.

📒 Files selected for processing (1)
  • .github/workflows/helm-upgrade-doc.yml

Comment thread .github/workflows/helm-upgrade-doc.yml
@guimoreirar
guimoreirar merged commit 66b7835 into develop Aug 4, 2026
36 of 37 checks passed
@github-actions
github-actions Bot deleted the chore/doc-helm-ops-team branch August 4, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR changes < 50 lines workflow Changes to one or more reusable workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants