feat(core)!: migrate to Fiber v3, cut /v2 major#27
Conversation
Bump gofiber/fiber v2.52.13 -> v3.4.0 (v2 dropped) and cut the /v2 module major. fiber.Ctx is now an interface passed by value: all *fiber.Ctx signatures across middleware/ and tracing/ drop the pointer. c.UserContext()/SetUserContext() -> c.Context()/SetContext(); app.Add now takes []string. No behavior change intended. BREAKING CHANGE: module path is now github.com/LerianStudio/lib-observability/v2 and exported HTTP helpers take fiber.Ctx by value; consumers must be on Fiber v3. X-Lerian-Ref: 0x1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (42)
📝 WalkthroughWalkthroughThe repository module path moved to Changesv2 Module and Fiber v3 Migration
Possibly related issues
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
🔒 Security Scan Results —
|
| Stage | Status | Blocking? |
|---|---|---|
| Filesystem Scan | ✅ Clean | — |
| Docker Image Scan | ➖ Skipped | — |
| Docker Hub Health Score | ➖ Skipped | — |
| Pre-release Version Check | ✅ Clean | — |
Trivy
Filesystem Scan
✅ No vulnerabilities or secrets found.
Pre-release Version Check
✅ No unstable version pins found.
📊 Unit Test Coverage Report:
|
| Metric | Value |
|---|---|
| Overall Coverage | 85.7% ✅ PASS |
| Threshold | 80% |
Coverage by Package
| Package | Coverage |
|---|---|
github.com/LerianStudio/lib-observability/v2/assert |
97.9% |
github.com/LerianStudio/lib-observability/v2/constants |
83.3% |
github.com/LerianStudio/lib-observability/v2/log |
94.9% |
github.com/LerianStudio/lib-observability/v2/metrics |
91.4% |
github.com/LerianStudio/lib-observability/v2/middleware |
76.9% |
github.com/LerianStudio/lib-observability/v2/redaction |
95.8% |
github.com/LerianStudio/lib-observability/v2/runtime |
80.4% |
github.com/LerianStudio/lib-observability/v2/tracing |
84.8% |
github.com/LerianStudio/lib-observability/v2/zap |
96.0% |
github.com/LerianStudio/lib-observability/v2 |
91.5% |
Generated by Go PR Analysis workflow
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Fiber v3 pulls golang.org/x/crypto via acme/autocert; the openpgp unmaintained advisory has no fixed version and the package is not imported. Matches the suppression already present on other services' develop. X-Lerian-Ref: 0x1
What
Migrates
lib-observabilityfrom Fiber v2 to Fiber v3.4.0 and cuts the/v2module major. First step of the coordinated org-wide Fiber v2→v3 migration (this library is the topological root —lib-commonsand everything downstream depend on it).Changes
github.com/LerianStudio/lib-observability/v2gofiber/fiberv2.52.13→v3.4.0(v2 dropped from go.mod)*fiber.Ctx→fiber.Ctx(v3 interface, by value) across all exported HTTP helpers inmiddleware/andtracing/c.UserContext()/SetUserContext()→c.Context()/SetContext();app.Addnow takes[]stringValidation
go build ./..., fullgo test -tags=unit ./...(843 tests),go vet,gofmt,goimports,golangci-lintall green.Coordinated-wave context
This is the only independently-mergeable PR in the wave (no cross-lib dependencies). Merge + publish order for the rest: lib-observability → lib-commons → {lib-auth, lib-license-go, lib-systemplane} → plugin-access-manager. Once this merges and tags
v2.0.0, the downstream libs bump to the realv2.0.0and stack their PRs.Breaking-change inventory + playbook: see internal-docs
infra-layer/fiber-v3-migration(PRs #230, #231).BREAKING CHANGE: consumers must move to
/v2and Fiber v3.