Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of branch losses #235

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Improve output of branch losses #235

merged 1 commit into from
Jun 5, 2024

Conversation

rdzman
Copy link
Member

@rdzman rdzman commented Jun 4, 2024

@WilsonGV, do you want to have a look at this? It should address your concerns from #234.

  • Add shunt loss columns (psh_fr, qsh_fr, psh_to, qsh_to) to branch data model.
  • Separate branch loss summary into series and shunt losses.
  • Add series loss columns to branch detail output (including new "Totals" row).

@WilsonGV
Copy link

WilsonGV commented Jun 5, 2024

Dear @rdzman

I've tested the changes and they work fine, even in a peace of code I'm developing. Thanks for your rapid response.

@rdzman
Copy link
Member Author

rdzman commented Jun 5, 2024

Great. Thanks. I'm going to rebase this on the latest master and then merge it.

- Add shunt loss columns (`psh_fr`, `qsh_fr`, `psh_to`, `qsh_to`) to branch data model.
- Separate branch loss summary into series and shunt losses.
- Add series loss columns to branch detail output.

Thanks to Wilson González Vanegas.

Ref: #234
@rdzman rdzman force-pushed the branch-losses-234 branch from d7b1a72 to e7f41f0 Compare June 5, 2024 23:05
@rdzman rdzman merged commit e7f41f0 into master Jun 5, 2024
5 checks passed
@rdzman rdzman deleted the branch-losses-234 branch June 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants