Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some random fixes + README update #71

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Some random fixes + README update #71

merged 7 commits into from
Jul 22, 2022

Conversation

Olek47
Copy link
Contributor

@Olek47 Olek47 commented Jul 16, 2022 •
edited
Loading

I added /redpiler and /toggleautorp commands to README and fixed two issues: #67 #69

@EwanFox
Copy link
Contributor

EwanFox commented Jul 16, 2022

Looks pretty good but for future reference its better to split different changes into multiple pull requests. Also not 100% sure about changing the no wires flag name given people are probably used to the current name.

@Olek47
Copy link
Contributor Author

Olek47 commented Jul 16, 2022

I changed it because its named "- optimize" on scoreboard.

StackDoubleFlow
StackDoubleFlow requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@StackDoubleFlow StackDoubleFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot going on here. As @BananaSquares noted, it would have been better to have these changes in separate pull requests.

Could you also run cargo fmt just to keep the formatting consistent?

README.md Outdated Show resolved Hide resolved
src/chat.rs Show resolved Hide resolved
src/chat.rs Show resolved Hide resolved
src/plot/commands.rs Outdated Show resolved Hide resolved
@StackDoubleFlow StackDoubleFlow linked an issue Jul 22, 2022 that may be closed by this pull request
Teleport to infinity and NaN! #67
Closed
@StackDoubleFlow StackDoubleFlow merged commit 9308c12 into MCHPR:master Jul 22, 2022
@Olek47 Olek47 mentioned this pull request Jul 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackDoubleFlow StackDoubleFlow StackDoubleFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teleport to infinity and NaN!
3 participants
@Olek47 @EwanFox @StackDoubleFlow