Open
Conversation
TimboTambo
approved these changes
Apr 13, 2021
StuartHarris
commented
Apr 23, 2021
| kubectl rollout restart deployment/argocd-server -n argocd | ||
| kubectl rollout restart deployment/doc-index-updater -n doc-index-updater | ||
| kubectl rollout restart deployment/medicines-api -n medicines-api | ||
| cd ../observability/prometheus && make |
Contributor
Author
There was a problem hiding this comment.
Small point, wondering if this line is valuable. Probs won't restart prometheus pods unless there's an update. Maybe we should update the readme to do the make instead? What do you think?
Contributor
There was a problem hiding this comment.
This command will be used when istio has been upgraded, in which case I think this line will cause the prometheus pod to restart due to istioctl kube-inject, which is what we want - is that right?
Contributor
Author
There was a problem hiding this comment.
Yep, that's true. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kube-state-metricsto work with the recently updated Kubernetes version (1.17)oms-agentmanifestsprometheus,oms-agentandkube-state-metricsunderobservabilityfolderMakefileincluster-initprometheusinstall