Skip to content

Observability with Istio 1.9 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StuartHarris wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Observability with Istio 1.9 #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5056b2f
update kube-state-metrics to support k8s 1.17
StuartHarris Apr 8, 2021
f2ec895
install prometheus
StuartHarris Apr 8, 2021
731ed9e
attempt at sidecar configuratio for prometheus
StuartHarris Apr 9, 2021
1e7241a
Add OUTPUT_CERTS env and volumeMount directly to istio container config
TimboTambo Apr 9, 2021
e2b4980
Add security context for prometheus container
TimboTambo Apr 12, 2021
f31119f
use kustomize to setup manifests before sidecar injection
StuartHarris Apr 12, 2021
82311c4
add configmap
StuartHarris Apr 12, 2021
64cb88a
tidy up, add readme etc
StuartHarris Apr 13, 2021
5e578bd
update kube-state-metrics manifests
StuartHarris Apr 13, 2021
52f5741
remove install.yaml files
StuartHarris Apr 13, 2021
fdcd676
ignore install.yaml
StuartHarris Apr 13, 2021
0c614e0
Add restart proxies make command and remove telemetry from profile
TimboTambo Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions istio/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ init1: ## Install SSL certs and Istio profile
init2: ## Install custom manifests
kustomize build overlays-2/$(overlay) | kubectl apply -f -

.PHONY: restart_proxies
restart_proxies: ## Restarts all istio dataplane proxies, can be used when rolling out upgrade
kubectl rollout restart deployment/argocd-application-controller -n argocd
kubectl rollout restart deployment/argocd-dex-server -n argocd
kubectl rollout restart deployment/argocd-redis -n argocd
kubectl rollout restart deployment/argocd-repo-server -n argocd
kubectl rollout restart deployment/argocd-server -n argocd
kubectl rollout restart deployment/doc-index-updater -n doc-index-updater
kubectl rollout restart deployment/medicines-api -n medicines-api
cd ../observability/prometheus && make
Copy link
Contributor Author

@StuartHarris StuartHarris Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small point, wondering if this line is valuable. Probs won't restart prometheus pods unless there's an update. Maybe we should update the readme to do the make instead? What do you think?

Copy link
Contributor

@TimboTambo TimboTambo Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command will be used when istio has been upgraded, in which case I think this line will cause the prometheus pod to restart due to istioctl kube-inject, which is what we want - is that right?

Copy link
Contributor Author

@StuartHarris StuartHarris Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's true. 👍


.PHONY: delete
delete: ## Remove Istio
kubectl delete istiooperators.install.istio.io -n istio-system istiocontrolplane --ignore-not-found || true
Expand Down
33 changes: 0 additions & 33 deletions istio/init-1/profile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,6 @@ spec:
meshConfig:
outboundTrafficPolicy:
mode: REGISTRY_ONLY
addonComponents:
kiali:
enabled: true
grafana:
enabled: false
prometheus:
enabled: true
tracing:
enabled: true
components:
pilot:
enabled: true
Expand All @@ -31,24 +22,6 @@ spec:
patches:
- path: spec.minReplicas
value: 2
telemetry:
enabled: true
k8s:
resources:
requests:
cpu: "200m"
memory: "500M"
overlays:
- kind: Deployment
name: istio-telemetry
patches:
- path: spec.replicas
value: 2
- kind: HorizontalPodAutoscaler
name: istio-telemetry
patches:
- path: spec.minReplicas
value: 2
ingressGateways:
- name: istio-ingressgateway
enabled: true
Expand All @@ -58,9 +31,3 @@ spec:
values:
sidecarInjectorWebhook:
rewriteAppHTTPProbe: true
telemetry:
enabled: true
v1:
enabled: false
v2:
enabled: true