Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds methods to add and update MISP roles #1264

Merged

Conversation

neok0
Copy link
Contributor

@neok0 neok0 commented Jul 22, 2024

This change simply adds two methods to add and update (existing) MISP roles, similar to existing add_X and update_X methods.

@Rafiot Rafiot self-assigned this Jul 23, 2024
@Rafiot
Copy link
Member

Rafiot commented Jul 23, 2024

Can you add a test in this test suite, please? If you don't have time, don't worry, I'll do it myself before merging.

@Rafiot Rafiot merged commit 4e85c93 into MISP:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants