Feature/#43 선수 포지션 리스트 가져오기 기능 개발 및 선수 검색 기능 수정 - #63
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough신규 ElementType 목록 조회 API를 추가하고 DTO/서비스/엔티티 매퍼를 도입했다. PlayerEs 검색 엔드포인트와 서비스 로직을 통합하여 단일 검색 메서드/엔드포인트로 변경하고 기존 두 엔드포인트를 주석 처리했다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Controller as PlayerEsController
participant Service as PlayerEsService
participant ES as Elasticsearch
Client->>Controller: GET /api/playerEs/search?keyword=&elementTypeId=
Controller->>Service: search(keyword, elementTypeId)
alt both blank
Service->>ES: match_all query (size=700)
else keyword only
Service->>ES: bool should(webName.ngram, krName.ngram) (min_should_match=1)
else elementTypeId only
Service->>ES: term query on elementTypeId.keyword
else both provided
Service->>ES: bool should(...) + must term(elementTypeId)
end
ES-->>Service: hits
Service-->>Controller: List<PlayerEsDocument>
Controller-->>Client: 200 OK
sequenceDiagram
autonumber
participant Client
participant C as ElementTypeController
participant S as ElementTypeService
participant Repo as ElementTypeRepository
participant Mapper as ElementType (toDtoList)
Client->>C: GET /api/elementType/all
C->>S: getAllElementType()
S->>Repo: findAll()
Repo-->>S: List<ElementType>
S->>Mapper: toDtoList(elementTypes)
Mapper-->>S: List<ElementTypeDto>
S-->>C: List<ElementTypeDto>
C-->>Client: 200 OK
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This was referenced Aug 20, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit