misc improvements on homing and feedrate #543
Conversation
_gcode/G028.md
Outdated
| @@ -6,7 +6,7 @@ author: thinkyhead | |||
|
|
|||
| group: calibration | |||
|
|
|||
| codes: [ G28 ] | |||
| codes: [ G28, G34 ] | |||
There was a problem hiding this comment.
Why was G34 added here? This is the G28 page, so it should be G28.
|
because G34 does G28 before it does anything else, and therefore an additional G28 is not needed. see also HOME_AFTER_G34 |
You changed the |
|
my bad. this should be better |
| @@ -7,6 +7,7 @@ author: thinkyhead | |||
| group: calibration | |||
|
|
|||
| codes: [ G28 ] | |||
| related: [ G34 ] | |||
There was a problem hiding this comment.
Lots of features will home if needed, so I’m not sure adding G34 here makes sense.
_gcode/G034-zsaa.md
Outdated
| @@ -38,4 +38,4 @@ example: | |||
|
|
|||
| --- | |||
|
|
|||
| Align multiple Z stepper motors using a bed probe by probing one position per stepper. See [`M422`](/docs/gcode/M422.html) for Z-Stepper automatic alignment parameter selection. | |||
| Align multiple Z stepper motors using a bed probe by probing one position per stepper. See [`M422`](/docs/gcode/M422.html) for Z-Stepper automatic alignment parameter selection. `G28` is done beforehand and is implicit. Also see `HOME_AFTER_G34` in `Configuration_adv.h` | |||
There was a problem hiding this comment.
G28 is only done if needed/axis positions are unknown, so this isn’t exactly correct.
There was a problem hiding this comment.
I now see the comment in G28: Homing is required before [G29](https://marlinfw.org/docs/gcode/G029.html), [M48](https://marlinfw.org/docs/gcode/M048.html), and some other procedures.
IMHO it would be worth it to figure out which procedures auto-home if required pr prefer to fail first, maybe standardize this
No description provided.