Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc improvements on homing and feedrate #543

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

misc improvements on homing and feedrate #543

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e67885
misc improvements on homing and feedrate
Feb 9, 2024
c722f15
more on G34
Feb 9, 2024
3b558bb
G34 in related
Feb 10, 2024
2f1ba9c
changes for pygcode automatic class generation
Mar 9, 2024
bfb1143
fixed some command for better class names in pygcode
Mar 9, 2024
914b4b5
M205 fix
Jun 3, 2024
4f6b137
M600 added ref to Configuration_adv.h
Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _gcode/G000-G001.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ parameters:

- tag: F
optional: true
description: The maximum movement rate of the move between the start and end point. The feedrate set here applies to subsequent moves that omit this parameter.
description: The maximum movement rate (in mm/min) of the move between the start and end point. The feedrate set here applies to subsequent moves that omit this parameter.
values:
- tag: rate
type: float
Expand Down
1 change: 1 addition & 0 deletions _gcode/G028.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ author: thinkyhead
group: calibration

codes: [ G28 ]
related: [ G34 ]
Copy link
Member

@thisiskeithb thisiskeithb Feb 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of features will home if needed, so I’m not sure adding G34 here makes sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


notes: |
- Homing is required before [`G29`](/docs/gcode/G029.html), [`M48`](/docs/gcode/M048.html), and some other procedures.
Expand Down
4 changes: 2 additions & 2 deletions _gcode/G034-zsaa.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ experimental: true
group: calibration

codes: [ G34 ]
related: [ M422, M906, M907 ]
related: [ G28, M422, M906, M907 ]

parameters:

Expand Down Expand Up @@ -38,4 +38,4 @@ example:

---

Align multiple Z stepper motors using a bed probe by probing one position per stepper. See [`M422`](/docs/gcode/M422.html) for Z-Stepper automatic alignment parameter selection.
Align multiple Z stepper motors using a bed probe by probing one position per stepper. See [`M422`](/docs/gcode/M422.html) for Z-Stepper automatic alignment parameter selection. `G28` is done beforehand and is implicit. Also see `HOME_AFTER_G34` in `Configuration_adv.h`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G28 is only done if needed/axis positions are unknown, so this isn’t exactly correct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now see the comment in G28: Homing is required before [G29](https://marlinfw.org/docs/gcode/G029.html), [M48](https://marlinfw.org/docs/gcode/M048.html), and some other procedures.

IMHO it would be worth it to figure out which procedures auto-home if required pr prefer to fail first, maybe standardize this